Fix implicitNotFound message for type aliases #19343
Conversation
joroKr21
force-pushed
the
implicit-not-found
branch
5 times, most recently
from
c550fdc
to
06f086b
Compare
| if (updateCheckFiles) { | ||
| FileDiff.dump(checkFile.toPath.toString, actual) | ||
| echo("Updated checkfile: " + checkFile.getPath) | ||
| } else { | ||
| onFailure(testSource, reporters, logger, Some(msg)) |
There was a problem hiding this comment.
Originally I left this one out to force users to re-run the tests against the new checkfile. This can be useful if there is a source of non-determinism in the output.
There was a problem hiding this comment.
I can revert this. Was pretty confusing initially but I might be biased by the Scala 2 experience.
There was a problem hiding this comment.
You can keep your change. There is no right or wrong way to do this. Your way might be easier to understand.
nicolasstucki
requested review from
mbovel
and removed request for
anatoliykmetyuk
|
Any chance to get a review? I'm not sure who to ping. I guess the 3.2 ship has sailed, but I hope we can backport it to 3.3 |
| @@ -2784,19 +2784,25 @@ class MissingImplicitArgument( | |||
| val idx = paramNames.indexOf(name) | |||
| if (idx >= 0) Some(i"${args(idx)}") else None | |||
| """\$\{\s*([^}\s]+)\s*\}""".r.replaceAllIn(raw, (_: Regex.Match) match | |||
| case Regex.Groups(v) => quoteReplacement(translate(v).getOrElse("")).nn | |||
| case Regex.Groups(v) => quoteReplacement(translate(v).getOrElse("?" + v)).nn | |||
| ) | |||
|
|
|||
| /** @param rawMsg Message template with variables, e.g. "Variable A is ${A}" | |||
| * @param sym Symbol of the annotated type or of the method whose parameter was annotated | |||
| * @param substituteType Function substituting specific types for abstract types associated with variables, e.g A -> Int | |||
There was a problem hiding this comment.
The documentation should be updated to include the new parameters.
| @@ -2784,19 +2784,25 @@ class MissingImplicitArgument( | |||
| val idx = paramNames.indexOf(name) | |||
| if (idx >= 0) Some(i"${args(idx)}") else None | |||
| """\$\{\s*([^}\s]+)\s*\}""".r.replaceAllIn(raw, (_: Regex.Match) match | |||
| case Regex.Groups(v) => quoteReplacement(translate(v).getOrElse("")).nn | |||
| case Regex.Groups(v) => quoteReplacement(translate(v).getOrElse("?" + v)).nn | |||
There was a problem hiding this comment.
We should maybe have a separate test case for the "?" case?
There was a problem hiding this comment.
We have this test case:
26 | summon[H[Int]] // error
| ^
| Not found for Int, ?B
There was a problem hiding this comment.
Yes, I wrote a separate test case because I think it could deserve its own tests, but that's okay like that.
joroKr21
force-pushed
the
implicit-not-found
branch
from
06f086b
to
d34ab6d
Compare
Fix #7092