Fix deadlock in initialization of CoreBTypes using Lazy container #19298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssorFrontendAcces.Lazy` container
…t `DottyBackendInterface.ctx`
sjrd
approved these changes
Dec 20, 2023
odersky
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 6, 2024
…ala#19298) Replaces scala#19297 and fixes scala#19293 The deadlocks are now fixed by introduction of `PostProcessorFrontendAccess.Lazy[T]` container for which initialization is synchronized with the frontend Context, while providing a thread-safe access lacking in original solution. It now also audits where the unrestricted access to context was used and replaces these usages with safer access. Reverts scala#19292
WojciechMazur
added a commit
that referenced
this pull request
Jul 10, 2024
…9298) Replaces #19297 and fixes #19293 The deadlocks are now fixed by introduction of `PostProcessorFrontendAccess.Lazy[T]` container for which initialization is synchronized with the frontend Context, while providing a thread-safe access lacking in original solution. It now also audits where the unrestricted access to context was used and replaces these usages with safer access. Reverts #19292 [Cherry-picked 33bdaac][modified]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #19297 and fixes #19293
The deadlocks are now fixed by introduction of
PostProcessorFrontendAccess.Lazy[T]container for which initialization is synchronized with the frontend Context, while providing a thread-safe access lacking in original solution.It now also audits where the unrestricted access to context was used and replaces these usages with safer access.
Reverts #19292