Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

presentation compiler: Bugfix for semantic tokens and synthetic decorations #18955

Merged
merged 2 commits into from
Nov 28, 2023
Merged

presentation compiler: Bugfix for semantic tokens and synthetic decorations #18955

merged 2 commits into from
Nov 28, 2023

Conversation

jkciesluk
Copy link
Contributor

@jkciesluk jkciesluk commented Nov 17, 2023 •
edited
Loading

@jkciesluk jkciesluk marked this pull request as draft November 17, 2023 12:40
@jkciesluk jkciesluk changed the title presentation compiler: Show semantic tokens for vals from predef as classes presentation compiler: Bugfix for semantic tokens and synthetic decorations Nov 28, 2023
@jkciesluk jkciesluk marked this pull request as ready for review November 28, 2023 10:32
tgodzik
tgodzik approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Nov 28, 2023
@tgodzik tgodzik merged commit fab3f21 into scala:main Nov 28, 2023
19 checks passed
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 25, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 26, 2024
@WojciechMazur
Backport "presentation compiler: Bugfix for semantic tokens and synth…
a8d4ac7 
…etic decorations" to LTS (#20780)

Backports #18955 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it.
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkciesluk @tgodzik @Kordyjan