Add checks for the consistency of the parents in TreeChecker #18935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This check is available under |
hamzaremmal
force-pushed
the
i18677
branch
3 times, most recently
from
3345567
to
72f0abf
Compare
nicolasstucki
assigned nicolasstucki and hamzaremmal and unassigned hamzaremmal and nicolasstucki
nicolasstucki
suggested changes
Feb 9, 2024
hamzaremmal
force-pushed
the
i18677
branch
2 times, most recently
from
563b3a1
to
1723086
Compare
nicolasstucki
suggested changes
Feb 12, 2024
nicolasstucki
suggested changes
Feb 12, 2024
| case _ => tree.symbol.isConstructor && tree.symbol.owner.is(Flags.Trait) | ||
| tree.symbol.is(Flags.Trait) || isTraitConstructor | ||
|
|
||
| val newParents = if impl.parents.tail eq newTraits then impl.parents |
There was a problem hiding this comment.
This is not the formatting we use for multiline expressions. It should be all on the right of the = or at the indented next line.
val newParents =
if impl.parents.tail eq newTraits then impl.parents
else impl.parents.head :: newTraitsThere was a problem hiding this comment.
We should have a document with "Best practices" when working on Dotty with some of these guidelines.
|
Otherwise LGTM |
nicolasstucki
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check for the parents in the TreeChecker.
In the context of macro annotations, this PR doesn't allow the modification of the parents. This restriction will probably be partially lifted as we come up with the final specification.
This PR is related to #18677 put does not close it.