Make Array.apply an intrinsic #18537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olhotak
approved these changes
Sep 19, 2023
| @@ -470,7 +470,7 @@ object Objects: | |||
|
|
|||
| /** Store the heap as a mutable field to avoid threading it through the program. */ | |||
| class MutableData(private[Heap] var heap: Data): | |||
| private[Heap] def update(addr: Addr, value: Value): Unit = | |||
| private[Heap] def writeUnion(addr: Addr, value: Value): Unit = | |||
There was a problem hiding this comment.
I wonder about the name change. Is the Union intended to convey that we update the heap with the join? In that case, I suggest writeJoin rather than writeUnion for consistency.
| @@ -489,8 +489,8 @@ object Objects: | |||
| def read(addr: Addr)(using mutable: MutableData): Value = | |||
| mutable.heap(addr) | |||
|
|
|||
| def write(addr: Addr, value: Value)(using mutable: MutableData): Unit = | |||
| mutable.update(addr, value) | |||
| def writeUnion(addr: Addr, value: Value)(using mutable: MutableData): Unit = | |||
There was a problem hiding this comment.
Without braces, it's hard to see which methods are part of class MutableData and which come after. Suggest an end line to indicate the end of MutableData.
liufengyun
force-pushed
the
init-global-array-apply
branch
from
a911d54
to
9e80e94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Array.applyan intrinsic