Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reversed wconf parsing order to mirror scala 2 #18503

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

johnmatthiggins
Copy link
Contributor

@johnmatthiggins johnmatthiggins commented Sep 3, 2023

These changes should fix #18367.

@som-snytt
Copy link
Contributor

Possible home for a test

./compiler/test/dotty/tools/dotc/config/ScalaSettingsTests.scala

@johnmatthiggins johnmatthiggins changed the title [wip] fix: reversed wconf parsing order to mirror scala 2 fix: reversed wconf parsing order to mirror scala 2 Sep 3, 2023
@johnmatthiggins johnmatthiggins marked this pull request as ready for review September 3, 2023 23:27
Copy link
Contributor

@jchyb jchyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing this

@jchyb jchyb merged commit 16dd58f into scala:main Sep 4, 2023
17 checks passed
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-Wconf options are processed incorrectly
4 participants