Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update presentation compiler with changes from PR 5287 #18301

Merged

Conversation

kasiaMarek
Copy link
Contributor

update scala3 presentation compiler with changes from scalameta/metals#5287

@kasiaMarek kasiaMarek changed the title update presentation compiler with changes in https://github.com/scalameta/metals/pull/5287 update presentation compiler with changes from PR 5287 Jul 27, 2023
@julienrf
Copy link
Contributor

Why are two identical pull requests in different repos needed?

@kasiaMarek kasiaMarek force-pushed the update-presentation-compiler-with-5287 branch from 945bcdd to 6488bc3 Compare July 28, 2023 08:31
@rochala
Copy link
Contributor

rochala commented Aug 1, 2023

We have to keep mtags in metals up to date until LTS 3.3.2 is released (this is the one that includes stable PC). Also it is wise to keep support for older version such as 3.2.2 for a bit longer. In the near future, mtags3 sources will completely depend on the presentation compiler.

@rochala rochala merged commit fa38cb8 into scala:main Aug 1, 2023
17 checks passed
@rochala rochala added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Aug 1, 2023
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
Kordyjan pushed a commit that referenced this pull request Dec 1, 2023
update scala3 presentation compiler with changes from
scalameta/metals#5287
[Cherry-picked fa38cb8]
Kordyjan pushed a commit that referenced this pull request Dec 7, 2023
update scala3 presentation compiler with changes from
scalameta/metals#5287
[Cherry-picked fa38cb8]
Kordyjan pushed a commit that referenced this pull request Dec 7, 2023
update scala3 presentation compiler with changes from
scalameta/metals#5287
[Cherry-picked fa38cb8]
Kordyjan added a commit that referenced this pull request Dec 8, 2023
…LTS (#19140)

Backports #18301 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants