Fix quotes with references to path dependent types #17081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-path-dependent-types-detection-in-quotes
branch
from
9d0008d
to
511b02f
Compare
nicolasstucki
force-pushed
the
fix-path-dependent-types-detection-in-quotes
branch
6 times, most recently
from
65ac9f3
to
d96d4f3
Compare
nicolasstucki
force-pushed
the
fix-path-dependent-types-detection-in-quotes
branch
3 times, most recently
from
a0e2a25
to
31d94d7
Compare
natsukagami
reviewed
Mar 27, 2023
Comment on lines
660
to
661
| for arg <- args if arg.isType do | ||
| assert(arg.tpe.isInstanceOf[TypeRef] || arg.tpe.isInstanceOf[TermRef], "Expected TypeRef or TermRef in Hole type args but got: " + arg.tpe) |
There was a problem hiding this comment.
I don't understand this change, can you explain why we do this?
There was a problem hiding this comment.
Before, we assumed that we could only have type references, a reference to a type on some arbitrary path that is represented with a TypeRef (T, x.T, y.x.T). But we missed singleton types represented with a TermRef (a.type, a.b.type, ...).
This was part of another fix that I split out of this PR (see #17138). I removed this change.
nicolasstucki
force-pushed
the
fix-path-dependent-types-detection-in-quotes
branch
from
31d94d7
to
f035f10
Compare
natsukagami
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.