Fix: -no-link-warnings does not work #17028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
reviewed
Mar 2, 2023
There was a problem hiding this comment.
Thanks for the pr @Dedelweiss!
So I'm not convinced that changing the value is worth it here since this would in theory be a breaking change for scaladoc or for people using this value already.
Dedelweiss
changed the title
ckipp01
reviewed
Mar 10, 2023
There was a problem hiding this comment.
Hey @Dedelweiss are you able to squash these commits and update the PR description as it's out of date now.
|
I took a bit of time and dug a bit deeper into what was going on here @Dedelweiss and I think there is a small misunderstanding. I explained further in #16694 (comment). We'll need to discuss how we proceed there first. |
Change spelling of noLinkWarning Correct test Correction and add condition for noLinkWarning Correction Correction Correction
Florian3k
approved these changes
Jun 16, 2023
ckipp01
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
This looks good to me. @Dedelweiss we'll probably want to document this somewhere. Maybe a draft pr in the scala lang site that we can merge once this is released?
Kordyjan
pushed a commit
that referenced
this pull request
Nov 23, 2023
## Goal
There are two purposes to this PR, the first is to add warning
suppression when the path to the file is inneficient and a warning
suppression flag is set.
The second one is to deprecate the current flag and introduce a new to
avoid the ambiguity. One for dead links with the current meaning, and
one with dead links in assets. The goal is to avoid the confusion with
overloading of the naming.
I wonder if I also change the name of the previous flag to be more
precise in its use.
## Flags
noLinkWarnings - Boolean
"-no-link-warnings",
"Avoid warnings for ambiguous and incorrect links in members look up.
Doesn't affect warnings for incorrect links of assets etc."
noLinkAssetWarnings - Boolean
"-no-link-asset-warnings",
"Avoid warnings for incorrect links of assets like images, static pages,
etc.",
false
## Before :
<img width="700" alt="Screenshot 2023-03-13 at 16 25 03"
src="https://user-images.githubusercontent.com/44496264/224748941-65f08ba5-0498-4a0c-82b4-38b3921fcddd.png">
## After :
<img width="700" alt="Screenshot 2023-03-13 at 16 28 02"
src="https://user-images.githubusercontent.com/44496264/224748976-dcd1825b-e4e7-48b4-b093-cc4f86a78fb0.png">
Fixes #16694
[Cherry-picked be70d46]
Kordyjan
pushed a commit
that referenced
this pull request
Nov 29, 2023
## Goal
There are two purposes to this PR, the first is to add warning
suppression when the path to the file is inneficient and a warning
suppression flag is set.
The second one is to deprecate the current flag and introduce a new to
avoid the ambiguity. One for dead links with the current meaning, and
one with dead links in assets. The goal is to avoid the confusion with
overloading of the naming.
I wonder if I also change the name of the previous flag to be more
precise in its use.
## Flags
noLinkWarnings - Boolean
"-no-link-warnings",
"Avoid warnings for ambiguous and incorrect links in members look up.
Doesn't affect warnings for incorrect links of assets etc."
noLinkAssetWarnings - Boolean
"-no-link-asset-warnings",
"Avoid warnings for incorrect links of assets like images, static pages,
etc.",
false
## Before :
<img width="700" alt="Screenshot 2023-03-13 at 16 25 03"
src="https://user-images.githubusercontent.com/44496264/224748941-65f08ba5-0498-4a0c-82b4-38b3921fcddd.png">
## After :
<img width="700" alt="Screenshot 2023-03-13 at 16 28 02"
src="https://user-images.githubusercontent.com/44496264/224748976-dcd1825b-e4e7-48b4-b093-cc4f86a78fb0.png">
Fixes #16694
[Cherry-picked be70d46]
Kordyjan
added a commit
that referenced
this pull request
Dec 8, 2023
Backports #17028 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
There are two purposes to this PR, the first is to add warning suppression when the path to the file is inneficient and a warning suppression flag is set.
The second one is to deprecate the current flag and introduce a new to avoid the ambiguity. One for dead links with the current meaning, and one with dead links in assets. The goal is to avoid the confusion with overloading of the naming.
I wonder if I also change the name of the previous flag to be more precise in its use.
Flags
noLinkWarnings - Boolean
"-no-link-warnings",
"Avoid warnings for ambiguous and incorrect links in members look up. Doesn't affect warnings for incorrect links of assets etc."
noLinkAssetWarnings - Boolean
"-no-link-asset-warnings",
"Avoid warnings for incorrect links of assets like images, static pages, etc.",
false
Before :
After :
Fixes #16694