Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WUnused: Fix unused warning in synthetic symbols #17020

Merged
merged 3 commits into from
Mar 6, 2023
Merged

WUnused: Fix unused warning in synthetic symbols #17020

merged 3 commits into from
Mar 6, 2023

Conversation

szymon-rd
Copy link
Contributor

Resolves #16925 #16926

@szymon-rd
Copy link
Contributor Author

szymon-rd commented Feb 28, 2023 •
edited
Loading

It's a bit of a heuristic, but it does solve these issues. Could you take a quick look at my changes @PaulCoral ?

@PaulCoral
Copy link
Contributor

This seems good to me, thank you for this 👍.
I will try to do something similar for #16679, just to remove false positive even if reporting won't be as complete.

(Also please note that I have less time to fix the issues as I have to go on with other projects)

@szymon-rd szymon-rd requested a review from Kordyjan March 1, 2023 13:56
KacperFKorban
KacperFKorban approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I wonder if it would be enough to only do it for Synthetic symbols, but it shouldn't make much of a difference.

Also it would be good to squash the commits

@Kordyjan Kordyjan merged commit 424da9f into scala:main Mar 6, 2023
This was referenced Mar 6, 2023
Closed
Closed
@SethTisue SethTisue changed the title WUnused: Fix unused warnining in synthetic symbols WUnused: Fix unused warning in synthetic symbols Mar 7, 2023
@Kordyjan Kordyjan added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Apr 12, 2023
@Kordyjan Kordyjan added this to the 3.3.0 backports milestone Apr 12, 2023
@Kordyjan Kordyjan mentioned this pull request Apr 13, 2023
Merged
Kordyjan added a commit that referenced this pull request Apr 14, 2023
@Kordyjan
Backport "WUnused: Fix unused warning in synthetic symbols" (#17248)
76ff4e9 
Backport #17020
@Kordyjan Kordyjan mentioned this pull request Apr 14, 2023
Merged
Kordyjan added a commit that referenced this pull request Apr 17, 2023
@Kordyjan
Backport "WUnused: Fix unused warning in synthetic symbols" (#17272)
cf6da33 
Backports #17020
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Apr 17, 2023
@Kordyjan Kordyjan modified the milestones: 3.3.0 backports, 3.3.1, 3.3.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KacperFKorban KacperFKorban KacperFKorban approved these changes

@Kordyjan Kordyjan Awaiting requested review from Kordyjan

Assignees

@Kordyjan Kordyjan

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

-Wunused gives false positives for generator value with a guard
4 participants
@szymon-rd @PaulCoral @KacperFKorban @Kordyjan