Improve New/Select -Ycheck message
#16746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mention that the constructor must be selected. This should be all the information needed in case someone writes a buggy macro that does not include the `Select` around the `New`. Closed scala#16357
smarter
approved these changes
Jan 23, 2023
| @@ -141,7 +141,7 @@ class TreeChecker extends Phase with SymTransformer { | |||
| override def apply(parent: Tree, tree: Tree)(using Context): Tree = { | |||
| tree match { | |||
| case tree: New if !parent.isInstanceOf[tpd.Select] => | |||
| assert(assertion = false, i"`New` node must be wrapped in a `Select`:\n parent = ${parent.show}\n child = ${tree.show}") | |||
| assert(assertion = false, i"`New` node must be wrapped in a `Select` of the constructor:\n parent = ${parent.show}\n child = ${tree.show}") | |||
There was a problem hiding this comment.
Maybe the message could mention how to do this for the reflection API? Is there an equivalent to nme.CONSTRUCTOR? Or a convenience method? Also maybe we should also check that if a Select exists, then the name selected has isConstructorName return true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mention that the constructor must be selected. This should be all the information needed in case someone writes a buggy macro that does not include the
Selectaround theNew.Closed #16357