Unpickle arguments of parent constructors in Templates lazily #16688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
changed the title
smarter
requested changes
Jan 13, 2023
Comment on lines
862
to
864
| def unforced: LazyTreeList[T] = preBody | ||
|
|
||
| protected def force(x: List[Tree[T @uncheckedVariance]]): Unit = preBody = x |
There was a problem hiding this comment.
These methods from WithLazyField won't cause myParentsOrDerived to be forced which may break various tree traversals where we call WithLazyField#forceIfLazy. It seems that WithLazyField needs to be generalized to support multiple lazy fields.
There was a problem hiding this comment.
In fact they do force myParentsOrDerived by the logic in Template but that logic is obscure. I cleaned it up.
|
Since this should get into 3,0 a review is time-critical. |
smarter
reviewed
Jan 16, 2023
Avoid reading the arguments of parent constructors unless someone forces them. We don't need them to determine the parent types of the class to which the template belongs. This makes TreeUnpickler as lazy as Namer in this respect and therefore avoids CyclicReferences during unpickling. Fixes scala#16673
sjrd
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid reading the arguments of parent constructors unless someone forces them. We don't need them to determine the parent types of the class to which the template belongs. This makes TreeUnpickler as lazy as Namer in this respect and therefore avoids CyclicReferences during unpickling.
Fixes #16673