Delay opaque alias checking until PostTyper #16644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have a TypeBounds tree that also has an alias, we checked that the alias is within bounds at Typer. This could provoke a CyclicReference when processing opaque type aliases where the type has a bound and also the alias refers back to the type. We avoid the problem by performing the check at PostTyper, analogous to other bounds checks. Fixes scala#16642
dwijnand
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a TypeBounds tree that also has an alias, we checked that the alias is within bounds at Typer. This could provoke a CyclicReference when processing opaque type aliases where the type has a bound and also the alias refers back to the type. We avoid the problem by performing the check at PostTyper, analogous to other bounds checks.
Fixes #16642