Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space: Refine isSubspace property & an example #16574

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Space: Refine isSubspace property & an example #16574

merged 4 commits into from
Jan 5, 2023

Conversation

dwijnand
Copy link
Member

  • Space: Avoid creating duplicates in simplify
  • Space: Make isSubspace use simplified spaces only, by recursing
  • Space: Avoid using return, so trace is easier to force
  • Space: Refine isSubspace property & an example

@dwijnand dwijnand marked this pull request as ready for review December 29, 2022 23:34
SethTisue
SethTisue approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dale explained this to me over Zoom — LGTM

@dwijnand dwijnand merged commit b65b0f2 into scala:main Jan 5, 2023
@dwijnand dwijnand deleted the space/various branch January 5, 2023 16:36
@Kordyjan Kordyjan added this to the 3.3.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dwijnand @SethTisue @Kordyjan