Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to silence focus-meta warning #298

Open
NoahTheDuke opened this issue Jul 1, 2022 · 2 comments
Open

Option to silence focus-meta warning #298

NoahTheDuke opened this issue Jul 1, 2022 · 2 comments
Labels
ergonomics Making Kaocha delightful to work with and people more efficient help wanted Extra attention is needed improvement Incremental improvement of an existing feature

Comments

@NoahTheDuke
Copy link
Contributor

Would it be possible to have an option to silence this warning?

(doseq [u unused]
(output/warn "No tests found with metadata key " u ". Ignoring --focus-meta " u "."))

I'm setting up kaocha as our company-wide test runner and most of the time folks won't be focusing single tests but it's helpful to have the metadata consistent for everyone, so printing the warning every time feels unnecessary.

I don't know if this is possible, but maybe only include the warning if the option is set from the command line? As I see it, when set in tests.edn it's meant to be constant and can be ignored, but when set from the cli, it's one-off and thus a warning is good to say "you chose this specifically, did you make a mistake?"

@plexus
Copy link
Member

plexus commented Jul 1, 2022

We'd like a general approach for opting out of specific warnings. Something where every type of warnings is identified by a keyword, and you can turn them off per type in tests.edn.

A proposal and PR in that vein would be very welcome!

@plexus plexus added improvement Incremental improvement of an existing feature help wanted Extra attention is needed ergonomics Making Kaocha delightful to work with and people more efficient labels Jul 1, 2022
@alysbrooks
Copy link
Member

#404 creates the infrastructure needed to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ergonomics Making Kaocha delightful to work with and people more efficient help wanted Extra attention is needed improvement Incremental improvement of an existing feature
Projects
Status: Candidate
Development

No branches or pull requests

3 participants