This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Fix how execution resources are handled during ExecuteEntryPoint::execute
#634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
ExecuteEntryPoint::_executeExecuteEntryPoint::execute
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 92.19% 92.21% +0.01%
==========================================
Files 49 49
Lines 10214 10235 +21
==========================================
+ Hits 9417 9438 +21
Misses 797 797
|
mmsc2
approved these changes
Jun 12, 2023
juanbono
suggested changes
Jun 12, 2023
Collaborator
juanbono
left a comment
juanbono
left a comment
There was a problem hiding this comment.
I think we should wait the merge of your PR in cairo-rs and update this one accordingly instead of enabling the trace
…ix-execution-resources-handling
Closed
mmsc2
approved these changes
Jun 13, 2023
juanbono
approved these changes
Jun 13, 2023
…ix-execution-resources-handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates cairo-vm to v0.5.2