From 10dee6d01f55a291ec89f07e7309db62a6dec563 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juli=C3=A1n=20Gonz=C3=A1lez=20Calder=C3=B3n?= Date: Fri, 28 Mar 2025 15:54:29 -0300 Subject: [PATCH] Replace todos with errors --- src/libfuncs.rs | 7 ++++--- src/libfuncs/gas.rs | 2 +- src/libfuncs/starknet.rs | 3 ++- src/types.rs | 12 +++++++----- src/values.rs | 2 +- 5 files changed, 15 insertions(+), 11 deletions(-) diff --git a/src/libfuncs.rs b/src/libfuncs.rs index a75385997d..9277e2c2e0 100644 --- a/src/libfuncs.rs +++ b/src/libfuncs.rs @@ -5,6 +5,7 @@ use crate::{ error::{panic::ToNativeAssertError, Error as CoreLibfuncBuilderError, Result}, metadata::MetadataStorage, + native_panic, types::TypeBuilder, utils::BlockExt, }; @@ -144,7 +145,7 @@ impl LibfuncBuilder for CoreConcreteLibfunc { Self::Debug(selector) => self::debug::build( context, registry, entry, location, helper, metadata, selector, ), - Self::Trace(_) => todo!("Implement trace libfunc"), + Self::Trace(_) => native_panic!("Implement trace libfunc"), Self::Drop(info) => { self::drop::build(context, registry, entry, location, helper, metadata, info) } @@ -164,7 +165,7 @@ impl LibfuncBuilder for CoreConcreteLibfunc { context, registry, entry, location, helper, metadata, selector, ), Self::Felt252SquashedDict(_) => { - todo!("Implement felt252_squashed_dict libfunc") + native_panic!("Implement felt252_squashed_dict libfunc") } Self::Felt252DictEntry(selector) => self::felt252_dict_entry::build( context, registry, entry, location, helper, metadata, selector, @@ -178,7 +179,7 @@ impl LibfuncBuilder for CoreConcreteLibfunc { Self::IntRange(selector) => self::int_range::build( context, registry, entry, location, helper, metadata, selector, ), - Self::Blake(_) => todo!("Implement blake libfunc"), + Self::Blake(_) => native_panic!("Implement blake libfunc"), Self::Mem(selector) => self::mem::build( context, registry, entry, location, helper, metadata, selector, ), diff --git a/src/libfuncs/gas.rs b/src/libfuncs/gas.rs index 4ddc8bf061..07be1f195e 100644 --- a/src/libfuncs/gas.rs +++ b/src/libfuncs/gas.rs @@ -48,7 +48,7 @@ pub fn build<'ctx, 'this>( build_get_builtin_costs(context, registry, entry, location, helper, metadata, info) } GasConcreteLibfunc::GetUnspentGas(_) => { - todo!("Implement GetUnspentGas libfunc"); + native_panic!("Implement GetUnspentGas libfunc"); } } } diff --git a/src/libfuncs/starknet.rs b/src/libfuncs/starknet.rs index a1be113310..512ac90805 100644 --- a/src/libfuncs/starknet.rs +++ b/src/libfuncs/starknet.rs @@ -5,6 +5,7 @@ use crate::{ error::{Error, Result}, ffi::get_struct_field_type_at, metadata::{drop_overrides::DropOverridesMeta, MetadataStorage}, + native_panic, starknet::handler::StarknetSyscallHandlerCallbacks, utils::{get_integer_layout, BlockExt, GepIndex, ProgramRegistryExt, PRIME}, }; @@ -140,7 +141,7 @@ pub fn build<'ctx, 'this>( context, registry, entry, location, helper, metadata, info, ), StarknetConcreteLibfunc::MetaTxV0(_) => { - todo!("Implement MetaTxV0 libfunc"); + native_panic!("Implement MetaTxV0 libfunc"); } #[cfg(feature = "with-cheatcode")] StarknetConcreteLibfunc::Testing(TestingConcreteLibfunc::Cheatcode(info)) => { diff --git a/src/types.rs b/src/types.rs index 89da79e153..6469f85fb2 100644 --- a/src/types.rs +++ b/src/types.rs @@ -436,7 +436,7 @@ impl TypeBuilder for CoreTypeConcrete { metadata, WithSelf::new(self_ty, info), ), - Self::Blake(_) => todo!("Build Blake type"), + Self::Blake(_) => native_panic!("Build Blake type"), } } @@ -543,7 +543,7 @@ impl TypeBuilder for CoreTypeConcrete { CoreTypeConcrete::Circuit(info) => circuit::is_complex(info), CoreTypeConcrete::IntRange(_info) => false, - CoreTypeConcrete::Blake(_info) => todo!("Implement is_complex for Blake type") + CoreTypeConcrete::Blake(_info) => native_panic!("Implement is_complex for Blake type") }) } @@ -628,7 +628,7 @@ impl TypeBuilder for CoreTypeConcrete { let type_info = registry.get_type(&info.ty)?; type_info.is_zst(registry)? } - CoreTypeConcrete::Blake(_info) => todo!("Implement is_zst for Blake type"), + CoreTypeConcrete::Blake(_info) => native_panic!("Implement is_zst for Blake type"), }) } @@ -739,7 +739,7 @@ impl TypeBuilder for CoreTypeConcrete { let inner = registry.get_type(&info.ty)?.layout(registry)?; inner.extend(inner)?.0 } - CoreTypeConcrete::Blake(_info) => todo!("Implement layout for Blake type"), + CoreTypeConcrete::Blake(_info) => native_panic!("Implement layout for Blake type"), } .pad_to_align()) } @@ -752,7 +752,9 @@ impl TypeBuilder for CoreTypeConcrete { // arguments. Ok(match self { CoreTypeConcrete::IntRange(_) => false, - CoreTypeConcrete::Blake(_info) => todo!("Implement is_memory_allocated for Blake type"), + CoreTypeConcrete::Blake(_info) => { + native_panic!("Implement is_memory_allocated for Blake type") + } CoreTypeConcrete::Array(_) => false, CoreTypeConcrete::Bitwise(_) => false, CoreTypeConcrete::Box(_) => false, diff --git a/src/values.rs b/src/values.rs index 8f85a922e7..531a529069 100644 --- a/src/values.rs +++ b/src/values.rs @@ -998,7 +998,7 @@ impl Value { y: y.into(), } } - CoreTypeConcrete::Blake(_) => todo!("Implement from_ptr for Blake type"), + CoreTypeConcrete::Blake(_) => native_panic!("Implement from_ptr for Blake type"), } }) }