From 4af17142990b4dd6792ae0bf51da54d90fa0bb94 Mon Sep 17 00:00:00 2001 From: FrancoGiachetta Date: Tue, 14 Jan 2025 11:44:04 -0300 Subject: [PATCH 1/2] upload comparison results in daily workflow as an artifact --- .github/ISSUE_TEMPLATE/daily_failure.md | 4 +--- .github/workflows/daily.yml | 15 ++++++++------- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/daily_failure.md b/.github/ISSUE_TEMPLATE/daily_failure.md index e607cfc4a7..2656aac7a4 100644 --- a/.github/ISSUE_TEMPLATE/daily_failure.md +++ b/.github/ISSUE_TEMPLATE/daily_failure.md @@ -12,6 +12,4 @@ Comparing VM execution against Native produced diffs: The transaction were not compared in order. You should rerun the whole failing block to find the error root -``` -{{ env.OUTPUT }} -``` +- State Diffs Comparisson: {{ env.COMPARISSON_RESULT }} diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml index 5d81b23525..869d842149 100644 --- a/.github/workflows/daily.yml +++ b/.github/workflows/daily.yml @@ -188,19 +188,20 @@ jobs: run: | ./scripts/cmp_state_dumps.sh | tee output + - name: Upload Compare Results + uses: actions/upload-artifact@v4 + if: ${{ always() }} + with: + name: output-result + path: output + - name: Prepare env vars if: ${{ always() }} run: | # Save workflow url REPO_URL="${{ github.server_url }}/${{ github.repository }}" echo "WORKFLOW_URL=$REPO_URL/actions/runs/${{ github.run_id }}" | tee -a $GITHUB_ENV - - # Save output - { - echo 'OUTPUT<> "$GITHUB_ENV" + echo "COMPARISSON_RESULT=$REPO_URL/actions/runs/${{ github.run_id }}/artifacts/${{ steps.upload_compare_results.outputs.artifact-id }}" | tee -a $GITHUB_ENV - name: Create Issue if: ${{ failure() }} From 6978c230f09ee0bc9b59d225f6d819b61329f7ad Mon Sep 17 00:00:00 2001 From: FrancoGiachetta Date: Tue, 14 Jan 2025 11:59:16 -0300 Subject: [PATCH 2/2] typo --- .github/ISSUE_TEMPLATE/daily_failure.md | 2 +- .github/workflows/daily.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/daily_failure.md b/.github/ISSUE_TEMPLATE/daily_failure.md index 2656aac7a4..42c231b170 100644 --- a/.github/ISSUE_TEMPLATE/daily_failure.md +++ b/.github/ISSUE_TEMPLATE/daily_failure.md @@ -12,4 +12,4 @@ Comparing VM execution against Native produced diffs: The transaction were not compared in order. You should rerun the whole failing block to find the error root -- State Diffs Comparisson: {{ env.COMPARISSON_RESULT }} +- State Diffs Comparison: {{ env.COMPARISON_RESULT }} diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml index 869d842149..ef04bb5b1d 100644 --- a/.github/workflows/daily.yml +++ b/.github/workflows/daily.yml @@ -201,7 +201,7 @@ jobs: # Save workflow url REPO_URL="${{ github.server_url }}/${{ github.repository }}" echo "WORKFLOW_URL=$REPO_URL/actions/runs/${{ github.run_id }}" | tee -a $GITHUB_ENV - echo "COMPARISSON_RESULT=$REPO_URL/actions/runs/${{ github.run_id }}/artifacts/${{ steps.upload_compare_results.outputs.artifact-id }}" | tee -a $GITHUB_ENV + echo "COMPARISON_RESULT=$REPO_URL/actions/runs/${{ github.run_id }}/artifacts/${{ steps.upload_compare_results.outputs.artifact-id }}" | tee -a $GITHUB_ENV - name: Create Issue if: ${{ failure() }}