add comments

Author: FrancoGiachetta

program.cairo

@@ -0,0 +1,29 @@
+use core::circuit::{
+            CircuitData, CircuitElement, CircuitInput, circuit_add, circuit_sub, circuit_mul, circuit_inverse,
+            EvalCircuitResult, EvalCircuitTrait, u384, CircuitOutputsTrait, CircuitModulus, into_u96_guarantee, U96Guarantee,
+            CircuitInputs, AddInputResultTrait, AddInputResult, IntoCircuitInputValue, add_circuit_input
+        };
+fn main() -> u384 {
+            let in1 = CircuitElement::<CircuitInput<0>> {};
+            let in2 = CircuitElement::<CircuitInput<1>> {};
+            let add1 = circuit_add(in1, in2);
+            let mul1 = circuit_mul(add1, in1);
+            let mul2 = circuit_mul(mul1, add1);
+            let inv1 = circuit_inverse(mul2);
+            let sub1 = circuit_sub(inv1, in2);
+            let sub2 = circuit_sub(sub1, mul2);
+            let inv2 = circuit_inverse(sub2);
+            let add2 = circuit_add(inv2, inv2);
+
+            let modulus = TryInto::<_, CircuitModulus>::try_into([17, 14, 14, 14]).unwrap();
+
+            let outputs = (add2,)
+                .new_inputs()
+                .next([9, 2, 9, 3])
+                .next([5, 7, 0, 8])
+                .done()
+                .eval(modulus)
+                .unwrap();
+
+            outputs.get_output(add2)
+        }

src/libfuncs/circuit.rs

@@ -398,7 +398,11 @@ fn build_eval<'ctx, 'this>(
                 location,
                 outputs_ptr,
                 &[GepIndex::Const(
-                    outputs_prefix_layout.size() as i32 + elem_stride.size() as i32 * i as i32,
+                    // The offset is calculated as the prefix, which is the 4 
+                    // bytes from the reference counter plus the extra padding.
+                    // Then, we need to add the element stride time the current
+                    // index.
+                    outputs_prefix_layout.size() as i32 + elem_stride.pad_to_align().size() as i32 * i as i32,
                 )],
                 IntegerType::new(context, 384).into(),
             )?;
@@ -942,12 +946,16 @@ fn build_get_output<'ctx, 'this>(
     )?;
 
     let circuit_output_prefix_offset = calc_circuit_output_prefix_layout().size() as i32;
-    let elem_stride = get_integer_layout(384).size() as i32;
+    let elem_stride = get_integer_layout(384).pad_to_align().size() as i32;
     let output_integer_ptr = entry.gep(
         context,
         location,
         circuit_ptr,
         &[GepIndex::Const(
+            // The offset is calculated as the prefix, which is the 4 
+            // bytes from the reference counter plus the extra padding.
+            // Then, we need to add the element stride time the current
+            // index.
             circuit_output_prefix_offset + elem_stride * output_idx as i32,
         )],
         u384_type,

src/metadata/trace_dump.rs

@@ -566,7 +566,6 @@ pub mod trace_dump_runtime {
                     else {
                         panic!("generic arg should be a Circuit");
                     };
-
                     let u96_layout = get_integer_layout(96);
 
                     let n_outputs = circuit.circuit_info.values.len();
@@ -586,7 +585,7 @@ pub mod trace_dump_runtime {
                     // get gate values
                     for i in 0..n_outputs {
                         let gate_ptr = value_ptr
-                            .byte_add(outputs_prefix_layout.size() + gate_stride.size() * i);
+                            .byte_add(outputs_prefix_layout.size() + gate_stride.pad_to_align().size() * i);
                         values.push(u384_struct_to_bigint(gate_ptr, 4));
                     }