Replace todos with errors (#1147)

Author: JulianGCalderon

src/libfuncs.rs

@@ -5,6 +5,7 @@
 use crate::{
     error::{panic::ToNativeAssertError, Error as CoreLibfuncBuilderError, Result},
     metadata::MetadataStorage,
+    native_panic,
     types::TypeBuilder,
     utils::BlockExt,
 };
@@ -144,7 +145,7 @@ impl LibfuncBuilder for CoreConcreteLibfunc {
             Self::Debug(selector) => self::debug::build(
                 context, registry, entry, location, helper, metadata, selector,
             ),
-            Self::Trace(_) => todo!("Implement trace libfunc"),
+            Self::Trace(_) => native_panic!("Implement trace libfunc"),
             Self::Drop(info) => {
                 self::drop::build(context, registry, entry, location, helper, metadata, info)
             }
@@ -164,7 +165,7 @@ impl LibfuncBuilder for CoreConcreteLibfunc {
                 context, registry, entry, location, helper, metadata, selector,
             ),
             Self::Felt252SquashedDict(_) => {
-                todo!("Implement felt252_squashed_dict libfunc")
+                native_panic!("Implement felt252_squashed_dict libfunc")
             }
             Self::Felt252DictEntry(selector) => self::felt252_dict_entry::build(
                 context, registry, entry, location, helper, metadata, selector,
@@ -178,7 +179,7 @@ impl LibfuncBuilder for CoreConcreteLibfunc {
             Self::IntRange(selector) => self::int_range::build(
                 context, registry, entry, location, helper, metadata, selector,
             ),
-            Self::Blake(_) => todo!("Implement blake libfunc"),
+            Self::Blake(_) => native_panic!("Implement blake libfunc"),
             Self::Mem(selector) => self::mem::build(
                 context, registry, entry, location, helper, metadata, selector,
             ),

src/libfuncs/gas.rs

@@ -48,7 +48,7 @@ pub fn build<'ctx, 'this>(
             build_get_builtin_costs(context, registry, entry, location, helper, metadata, info)
         }
         GasConcreteLibfunc::GetUnspentGas(_) => {
-            todo!("Implement GetUnspentGas libfunc");
+            native_panic!("Implement GetUnspentGas libfunc");
         }
     }
 }

src/libfuncs/starknet.rs

@@ -5,6 +5,7 @@ use crate::{
     error::{Error, Result},
     ffi::get_struct_field_type_at,
     metadata::{drop_overrides::DropOverridesMeta, MetadataStorage},
+    native_panic,
     starknet::handler::StarknetSyscallHandlerCallbacks,
     utils::{get_integer_layout, BlockExt, GepIndex, ProgramRegistryExt, PRIME},
 };
@@ -140,7 +141,7 @@ pub fn build<'ctx, 'this>(
             context, registry, entry, location, helper, metadata, info,
         ),
         StarknetConcreteLibfunc::MetaTxV0(_) => {
-            todo!("Implement MetaTxV0 libfunc");
+            native_panic!("Implement MetaTxV0 libfunc");
         }
         #[cfg(feature = "with-cheatcode")]
         StarknetConcreteLibfunc::Testing(TestingConcreteLibfunc::Cheatcode(info)) => {

src/types.rs

@@ -436,7 +436,7 @@ impl TypeBuilder for CoreTypeConcrete {
                 metadata,
                 WithSelf::new(self_ty, info),
             ),
-            Self::Blake(_) => todo!("Build Blake type"),
+            Self::Blake(_) => native_panic!("Build Blake type"),
         }
     }
 
@@ -543,7 +543,7 @@ impl TypeBuilder for CoreTypeConcrete {
             CoreTypeConcrete::Circuit(info) => circuit::is_complex(info),
 
             CoreTypeConcrete::IntRange(_info) => false,
-            CoreTypeConcrete::Blake(_info) => todo!("Implement is_complex for Blake type")
+            CoreTypeConcrete::Blake(_info) => native_panic!("Implement is_complex for Blake type")
         })
     }
 
@@ -628,7 +628,7 @@ impl TypeBuilder for CoreTypeConcrete {
                 let type_info = registry.get_type(&info.ty)?;
                 type_info.is_zst(registry)?
             }
-            CoreTypeConcrete::Blake(_info) => todo!("Implement is_zst for Blake type"),
+            CoreTypeConcrete::Blake(_info) => native_panic!("Implement is_zst for Blake type"),
         })
     }
 
@@ -739,7 +739,7 @@ impl TypeBuilder for CoreTypeConcrete {
                 let inner = registry.get_type(&info.ty)?.layout(registry)?;
                 inner.extend(inner)?.0
             }
-            CoreTypeConcrete::Blake(_info) => todo!("Implement layout for Blake type"),
+            CoreTypeConcrete::Blake(_info) => native_panic!("Implement layout for Blake type"),
         }
         .pad_to_align())
     }
@@ -752,7 +752,9 @@ impl TypeBuilder for CoreTypeConcrete {
         // arguments.
         Ok(match self {
             CoreTypeConcrete::IntRange(_) => false,
-            CoreTypeConcrete::Blake(_info) => todo!("Implement is_memory_allocated for Blake type"),
+            CoreTypeConcrete::Blake(_info) => {
+                native_panic!("Implement is_memory_allocated for Blake type")
+            }
             CoreTypeConcrete::Array(_) => false,
             CoreTypeConcrete::Bitwise(_) => false,
             CoreTypeConcrete::Box(_) => false,

src/values.rs

@@ -998,7 +998,7 @@ impl Value {
                         y: y.into(),
                     }
                 }
-                CoreTypeConcrete::Blake(_) => todo!("Implement from_ptr for Blake type"),
+                CoreTypeConcrete::Blake(_) => native_panic!("Implement from_ptr for Blake type"),
             }
         })
     }