-
Notifications
You must be signed in to change notification settings - Fork 208
Fix compute_ids_high_low hint constant path #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark Results for unmodified programs 🚀
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x.y #2193 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 103 103
Lines 43645 43645
=======================================
Hits 42190 42190
Misses 1455 1455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiegoCivi
approved these changes
Sep 3, 2025
gabrielbosio
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compute_ids_high_lowhint implementation was looking for the required constants at the wrong path (math.assert_250_bitinstead offield.assert_165_bit). As the fallback is to find the constant by ignoring the prefix, this error didn't come up in our tests.Checklist