From f3c8eafb8d67eb5557090c1ee956756bdc695e3b Mon Sep 17 00:00:00 2001 From: FrancoGiachetta Date: Fri, 14 Mar 2025 16:12:06 -0300 Subject: [PATCH 1/5] fix comment --- program.cairo | 24 ++++++++++++++++++++++++ vm/src/vm/runners/cairo_runner.rs | 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 program.cairo diff --git a/program.cairo b/program.cairo new file mode 100644 index 0000000000..ee40be1f65 --- /dev/null +++ b/program.cairo @@ -0,0 +1,24 @@ +%builtins output range_check bitwise keccak poseidon range_check96 add_mod mul_mod + +from starkware.cairo.common.cairo_builtins import ( + BitwiseBuiltin, + KeccakBuiltin, + PoseidonBuiltin, + ModBuiltin, + HashBuiltin, + SignatureBuiltin, + EcOpBuiltin, +) + +func main{ + output_ptr: felt*, + range_check_ptr, + bitwise_ptr: BitwiseBuiltin*, + keccak_ptr: KeccakBuiltin*, + poseidon_ptr: PoseidonBuiltin*, + range_check96_ptr: felt*, + add_mod_ptr: ModBuiltin*, + mul_mod_ptr: ModBuiltin*, +}() { + return (); +} diff --git a/vm/src/vm/runners/cairo_runner.rs b/vm/src/vm/runners/cairo_runner.rs index e0f27b4562..53f562cce1 100644 --- a/vm/src/vm/runners/cairo_runner.rs +++ b/vm/src/vm/runners/cairo_runner.rs @@ -270,7 +270,7 @@ impl CairoRunner { } /// Creates the builtin runners according to the builtins used by the program and the selected layout - /// When running in proof_mode, all builtins in the layout will be created, and only those in the program will be included + /// When running in proof_mode, all builtins in the layout will be created included /// When not running in proof_mode, only program builtins will be created and included /// Unless `allow_missing_builtins` is set to true, an error will be returned if a builtin is included in the program but not on the layout pub fn initialize_builtins(&mut self, allow_missing_builtins: bool) -> Result<(), RunnerError> { From 4bfbf92088940270a59817be3f09c60d1ad5f418 Mon Sep 17 00:00:00 2001 From: FrancoGiachetta Date: Fri, 14 Mar 2025 16:18:21 -0300 Subject: [PATCH 2/5] fix comment --- program.cairo | 24 ------------------------ 1 file changed, 24 deletions(-) delete mode 100644 program.cairo diff --git a/program.cairo b/program.cairo deleted file mode 100644 index ee40be1f65..0000000000 --- a/program.cairo +++ /dev/null @@ -1,24 +0,0 @@ -%builtins output range_check bitwise keccak poseidon range_check96 add_mod mul_mod - -from starkware.cairo.common.cairo_builtins import ( - BitwiseBuiltin, - KeccakBuiltin, - PoseidonBuiltin, - ModBuiltin, - HashBuiltin, - SignatureBuiltin, - EcOpBuiltin, -) - -func main{ - output_ptr: felt*, - range_check_ptr, - bitwise_ptr: BitwiseBuiltin*, - keccak_ptr: KeccakBuiltin*, - poseidon_ptr: PoseidonBuiltin*, - range_check96_ptr: felt*, - add_mod_ptr: ModBuiltin*, - mul_mod_ptr: ModBuiltin*, -}() { - return (); -} From 9d4f1a2c0991033c0d22786816f6743547720a3a Mon Sep 17 00:00:00 2001 From: FrancoGiachetta Date: Fri, 14 Mar 2025 16:22:26 -0300 Subject: [PATCH 3/5] fix --- vm/src/vm/runners/cairo_runner.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vm/src/vm/runners/cairo_runner.rs b/vm/src/vm/runners/cairo_runner.rs index 53f562cce1..5001273b0b 100644 --- a/vm/src/vm/runners/cairo_runner.rs +++ b/vm/src/vm/runners/cairo_runner.rs @@ -270,7 +270,7 @@ impl CairoRunner { } /// Creates the builtin runners according to the builtins used by the program and the selected layout - /// When running in proof_mode, all builtins in the layout will be created included + /// When running in proof_mode, all builtins in the layout will be created and included /// When not running in proof_mode, only program builtins will be created and included /// Unless `allow_missing_builtins` is set to true, an error will be returned if a builtin is included in the program but not on the layout pub fn initialize_builtins(&mut self, allow_missing_builtins: bool) -> Result<(), RunnerError> { From 3411fb60fba6c99eb639d4bc92b06cf79d4a7a41 Mon Sep 17 00:00:00 2001 From: FrancoGiachetta Date: Wed, 19 Mar 2025 10:08:03 -0300 Subject: [PATCH 4/5] change comment --- vm/src/vm/runners/cairo_runner.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/vm/src/vm/runners/cairo_runner.rs b/vm/src/vm/runners/cairo_runner.rs index a557f30a69..59e6872c9e 100644 --- a/vm/src/vm/runners/cairo_runner.rs +++ b/vm/src/vm/runners/cairo_runner.rs @@ -270,9 +270,11 @@ impl CairoRunner { } /// Creates the builtin runners according to the builtins used by the program and the selected layout - /// When running in proof_mode, all builtins in the layout will be created and included + /// When running in proof_mode, all builtins in the layout will be created, and only those in the program will be included /// When not running in proof_mode, only program builtins will be created and included /// Unless `allow_missing_builtins` is set to true, an error will be returned if a builtin is included in the program but not on the layout + /// + /// NOTE: 'included' does not refer to the builtin being included in the builtin runners but rather to the flag `included` in a builtin. pub fn initialize_builtins(&mut self, allow_missing_builtins: bool) -> Result<(), RunnerError> { let builtin_ordered_list = vec![ BuiltinName::output, From edf4479da0db17d6b7bafeaeb9ffbaa36b428798 Mon Sep 17 00:00:00 2001 From: FrancoGiachetta Date: Wed, 19 Mar 2025 10:16:20 -0300 Subject: [PATCH 5/5] format --- vm/src/vm/runners/cairo_runner.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vm/src/vm/runners/cairo_runner.rs b/vm/src/vm/runners/cairo_runner.rs index 59e6872c9e..9c97220440 100644 --- a/vm/src/vm/runners/cairo_runner.rs +++ b/vm/src/vm/runners/cairo_runner.rs @@ -273,7 +273,7 @@ impl CairoRunner { /// When running in proof_mode, all builtins in the layout will be created, and only those in the program will be included /// When not running in proof_mode, only program builtins will be created and included /// Unless `allow_missing_builtins` is set to true, an error will be returned if a builtin is included in the program but not on the layout - /// + /// /// NOTE: 'included' does not refer to the builtin being included in the builtin runners but rather to the flag `included` in a builtin. pub fn initialize_builtins(&mut self, allow_missing_builtins: bool) -> Result<(), RunnerError> { let builtin_ordered_list = vec![