Skip to content

Fix broken num-prime crate #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrancoGiachetta merged 3 commits into from
Nov 14, 2024
+3 −1
Merged

Fix broken num-prime crate #1873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13f4aea
Fix broken num-prime crate
edg-l Nov 14, 2024
bb338be
changelog
edg-l Nov 14, 2024
5fcf343
try
edg-l Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## Cairo-VM Changelog

#### Upcoming Changes
* fix: [#1873](https://github.com/lambdaclass/cairo-vm/pull/1873)
* Fix broken num-prime `is_prime` call
* fix: [#1868](https://github.com/lambdaclass/cairo-vm/pull/1855):
* Adds logic to include the 3 new builtins in `builtin_segments` when serializing the output cairo pie's metadata.

Expand Down
2 changes: 1 addition & 1 deletion vm/src/math_utils/is_prime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ mod with_std {
use num_bigint::BigUint;

pub fn is_prime(n: &BigUint) -> bool {
num_prime::nt_funcs::is_prime(n, None).probably()
num_prime::nt_funcs::is_prime::<BigUint>(n, None).probably()
}
}

Expand Down
Loading