Skip to content

Add --run_from_cairo_pie to cairo-vm-cli + workflow #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 109 commits into from
Apr 29, 2024
Merged

Add --run_from_cairo_pie to cairo-vm-cli + workflow #1730

merged 109 commits into from
Apr 29, 2024

Conversation

@fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Apr 23, 2024 •
edited
Loading

Depends on #1729 & #1720
Adds --run_from_cairo_pie to cairo-vm-cli
Adds a workflow that runs all test programs's pies and compares the trace, memory and pie outputs against cairo_lang

fmoletta and others added 30 commits April 16, 2024 18:11
@fmoletta
Implement CairoPieMetadata validity checks
a231575
@fmoletta
Save progres
3f99b46
@fmoletta
Progress
b071346
@fmoletta
Progress
9ce9aea
@fmoletta
Clippy
c79c02a
@fmoletta
Impl generic serialization for suffixed ver
f8e8029
@fmoletta
Implement custom generic deserialization
e821c04
@fmoletta
Rename module
3c4a417
@fmoletta
Complete API
cac3156
@fmoletta
Add docs & examples
72c1a6b
@fmoletta
Fix docs
2652145
@fmoletta
Remove reference from method
4dd4e2b
@fmoletta
Add clippy allow
fc31dc6
@fmoletta
Add changelog entry
898bb0e
@fmoletta
Add no-std import
7799173
@fmoletta
Merge branch 'main' into use-builtin-name
922f963
@fmoletta
Fix
c49bb4b
@fmoletta
Merge branch 'use-builtin-name' of https://github.com/lambdaclass/cai…
55d70b7 
…ro-vm into use-builtin-name
@fmoletta
fmt
107a637
@fmoletta
Use a wrapper for CairoPie additional data
f8d0082
@fmoletta
Update changelog
92e69ee
@fmoletta
Fix tests + fmt
5b54cfa
@fmoletta
Merge branch 'main' of https://github.com/lambdaclass/cairo-vm into u…
4730d7c 
…se-builtin-name
@fmoletta
Merge branch 'main' of https://github.com/lambdaclass/cairo-vm into r…
96141a6 
…un-from-cairo-pie
@fmoletta
Merge with BuiltinName branch + add memory validity checks
60b3950
@fmoletta
Add test for validity checks
059e139
@fmoletta
Start implementing cairo_run_pie
4f3e259
@fmoletta
Implement extend_additional_data for hash
0fd1c39
@fmoletta
Handle check
c1a221d
@fmoletta
Simplify
4b36813
@fmoletta fmoletta changed the title [WIP] Add --run_from_cairo_pie to cairo-vm-cli + workflow Add --run_from_cairo_pie to cairo-vm-cli + workflow Apr 25, 2024
@fmoletta fmoletta marked this pull request as ready for review April 25, 2024 18:38
juanbono
juanbono approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pefontana pefontana added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 0df3f34 Apr 29, 2024
@pefontana pefontana deleted the cairo-pie-cli branch April 29, 2024 19:04
pefontana pushed a commit that referenced this pull request May 7, 2024
Revert "Add --run_from_cairo_pie to cairo-vm-cli + workflow (#1730)"
2cb8729 
This reverts commit 0df3f34.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanbono juanbono juanbono approved these changes

@pefontana pefontana pefontana approved these changes

@igaray igaray Awaiting requested review from igaray

@Oppen Oppen Awaiting requested review from Oppen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmoletta @juanbono @pefontana