-
Notifications
You must be signed in to change notification settings - Fork 210
Compute ExecutionResources.n_steps without requiring trace
#1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1222 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 89 89
Lines 36166 36201 +35
=======================================
+ Hits 35296 35331 +35
Misses 870 870
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Benchmark Results for unmodified programs 🚀
|
pefontana
approved these changes
Jun 12, 2023
juanbono
approved these changes
Jun 12, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
…lass#1222) * Get n_steps without using trace * Add cahngelog entry --------- Co-authored-by: Pedro Fontana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if original steps is not set and trace is not enabled the number of steps in the
ExecutionResourcesreturned byCairoRunner::get_execution_resourcesis always 0. There are cases, such as starknet_in_rust, where execution resources are used but there is no use for the trace. In order to not slow down other projects that have no use for the trace,CairoRunner::get_execution_resourceswill now usevm.current_stepas n_steps if original steps or trace are not availableChecklist