refactor: Remove unused code & use constants whenever possible for builtin instance definitions (#1707)

* Reduce BitwiseInstanceDef

* Cleanup module

* Fixes

* Yeet CpuInstanceDef

* Update tests

* Simplify ec op instance def

* Clean Ecdsa instance def

* Clean Keccak instance def

* Update tests

* Clean Pedersen instance def

* Remove instances_per_component field

* Use the constants instead of storing a value for n_input cells and cells_per_instance for all builtins

* Extract memory_units_per_step into a constant

* Remove underscore from used field

* Remove unused field _cpu_component_step

* Remove unused field _n_trace_columns

* Impl Default for PoseidonInstanceDef

* Fix test

* Fix test

* fmt

* Add changelog entry

* Fix field name

Author: fmoletta

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 #### Upcoming Changes
 
+* refactor: Remove unused code & use constants whenever possible for builtin instance definitions[#1707](https://github.com/lambdaclass/cairo-vm/pull/1707)
+
 * fix(BREAKING): Use program builtins in `initialize_main_entrypoint` & `read_return_values`[#1703](https://github.com/lambdaclass/cairo-vm/pull/1703)
   * `initialize_main_entrypoint` now iterates over the program builtins when building the stack & inserts 0 for any missing builtin
   * `read_return_values` now only computes the final stack of the builtins in the program

vm/src/hint_processor/builtin_hint_processor/blake2s_utils.rs

@@ -301,7 +301,6 @@ mod tests {
             hint_processor_definition::HintProcessorLogic,
         },
         relocatable,
-        types::exec_scope::ExecutionScopes,
         utils::test_utils::*,
         vm::errors::memory_errors::MemoryError,
     };

vm/src/hint_processor/builtin_hint_processor/cairo_keccak/keccak_hints.rs

@@ -375,7 +375,7 @@ mod tests {
             },
             hint_processor_definition::{HintProcessorLogic, HintReference},
         },
-        types::{exec_scope::ExecutionScopes, relocatable::Relocatable},
+        types::relocatable::Relocatable,
         utils::test_utils::*,
         vm::vm_core::VirtualMachine,
     };

vm/src/hint_processor/builtin_hint_processor/ec_utils.rs

@@ -220,7 +220,6 @@ mod tests {
     use crate::hint_processor::builtin_hint_processor::builtin_hint_processor_definition::HintProcessorData;
     use crate::hint_processor::hint_processor_definition::HintProcessorLogic;
     use crate::relocatable;
-    use crate::types::exec_scope::ExecutionScopes;
     use crate::types::relocatable::Relocatable;
     use num_traits::Zero;
 

vm/src/hint_processor/builtin_hint_processor/field_arithmetic.rs

@@ -274,7 +274,6 @@ mod tests {
             },
             hint_processor_definition::HintProcessorLogic,
         },
-        types::exec_scope::ExecutionScopes,
         utils::test_utils::*,
         vm::vm_core::VirtualMachine,
     };

vm/src/hint_processor/builtin_hint_processor/garaga.rs

@@ -29,7 +29,6 @@ mod tests {
     use crate::hint_processor::builtin_hint_processor::builtin_hint_processor_definition::BuiltinHintProcessor;
     use crate::hint_processor::builtin_hint_processor::builtin_hint_processor_definition::HintProcessorData;
     use crate::hint_processor::hint_processor_definition::HintProcessorLogic;
-    use crate::types::exec_scope::ExecutionScopes;
     use crate::Felt252;
     use crate::{hint_processor::builtin_hint_processor::hint_code, utils::test_utils::*};
 

vm/src/hint_processor/builtin_hint_processor/keccak_utils.rs

@@ -297,7 +297,6 @@ mod tests {
             },
             hint_processor_definition::{HintProcessorLogic, HintReference},
         },
-        types::exec_scope::ExecutionScopes,
         utils::test_utils::*,
         vm::vm_core::VirtualMachine,
     };

vm/src/hint_processor/builtin_hint_processor/poseidon_utils.rs

@@ -57,7 +57,6 @@ mod tests {
     use crate::hint_processor::builtin_hint_processor::builtin_hint_processor_definition::HintProcessorData;
     use crate::hint_processor::hint_processor_definition::HintProcessorLogic;
     use crate::hint_processor::hint_processor_definition::HintReference;
-    use crate::types::exec_scope::ExecutionScopes;
     use crate::vm::vm_core::VirtualMachine;
 
     use crate::{hint_processor::builtin_hint_processor::hint_code, utils::test_utils::*};

vm/src/hint_processor/builtin_hint_processor/pow_utils.rs

@@ -45,7 +45,7 @@ mod tests {
             builtin_hint_processor::builtin_hint_processor_definition::HintProcessorData,
             hint_processor_definition::HintProcessorLogic,
         },
-        types::{exec_scope::ExecutionScopes, relocatable::MaybeRelocatable},
+        types::relocatable::MaybeRelocatable,
         utils::test_utils::*,
         vm::{errors::memory_errors::MemoryError, vm_core::VirtualMachine},
     };

vm/src/hint_processor/builtin_hint_processor/segments.rs

@@ -57,7 +57,6 @@ mod tests {
             },
             hint_processor_definition::HintProcessorLogic,
         },
-        types::exec_scope::ExecutionScopes,
         utils::test_utils::*,
         vm::vm_core::VirtualMachine,
     };