Skip to content

Commit 09fa5d8

Browse files
Sort_ecdsa_and_mod_builtins_private_inputs_by_idx
1 parent 3fb0344 commit 09fa5d8

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
#### Upcoming Changes
44

5+
* fix: [#1851](https://github.com/lambdaclass/cairo-vm/pull/1851):
6+
* Fix unsorted signature and mod builtin outputs in air_private_input.
7+
58
* feat(BREAKING): [#1824](https://github.com/lambdaclass/cairo-vm/pull/1824)[#1838](https://github.com/lambdaclass/cairo-vm/pull/1838):
69
* Add support for dynamic layout
710
* CLI change(BREAKING): The flag `cairo_layout_params_file` must be specified when using dynamic layout.

vm/src/vm/runners/builtin_runner/modulo.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,8 @@ impl ModBuiltinRunner {
263263
});
264264
}
265265

266+
instances.sort_by_key(|input| input.index);
267+
266268
vec![PrivateInput::Mod(ModInput {
267269
instances,
268270
zero_value_address: relocation_table

vm/src/vm/runners/builtin_runner/signature.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,10 @@ impl SignatureBuiltinRunner {
238238
}))
239239
}
240240
}
241+
private_inputs.sort_by_key(|input| match input {
242+
PrivateInput::Signature(sig) => sig.index,
243+
_ => unreachable!(),
244+
});
241245
private_inputs
242246
}
243247
}

0 commit comments

Comments
 (0)