fix: overflow in n_pair_bits
#1209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
requested review from
Juan-M-V,
entropidelic,
fmoletta,
igaray,
juanbono and
pefontana
as code owners
Replace a substraction and shift-based logic by `.checked_sub` and finding the right bit to avoid a `panic`. Also fixed a bug where `m >= 253` would store the result with the wrong id for `DI_BIT` hint. Fixes #1205
Oppen
force-pushed
the
fix/sub_overflow_ec_utils
branch
from
2bc7808 to
7d01145
Compare
|
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1209 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 89 89
Lines 36113 36159 +46
=======================================
+ Hits 35243 35289 +46
Misses 870 870
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MegaRedHand
approved these changes
Jun 6, 2023
| let m = m_cow.as_ref().to_u32().unwrap_or(253); | ||
| if m >= 253 { | ||
| return insert_value_from_var_name("quad_bit", 0, vm, ids_data, ap_tracking); | ||
| return insert_value_from_var_name(result_name, 0, vm, ids_data, ap_tracking); |
| // ↓↓ | ||
| // 1010101__ -> 101010110 | ||
| let get_bit = | ||
| |x: &BigUint, i| m.checked_sub(i).map(|i| x.bit(i.into())).unwrap_or(false) as u32; |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| |x: &BigUint, i| m.checked_sub(i).map(|i| x.bit(i.into())).unwrap_or(false) as u32; | |
| |x: &BigUint, i| m.checked_sub(i).map(|j| x.bit(j.into())).unwrap_or(false) as u32; |
Collaborator
There was a problem hiding this comment.
I think your suggestion needs to change the closure parameter name too right?
Contributor
There was a problem hiding this comment.
No. Both the closure and the closure inside the closure have a parameter named i. My suggestion is to rename the inner one to j to avoid variable shadowing.
juanbono
approved these changes
Jun 6, 2023
pefontana
approved these changes
Jun 7, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* fix: overflow in `n_pair_bits` Replace a substraction and shift-based logic by `.checked_sub` and finding the right bit to avoid a `panic`. Also fixed a bug where `m >= 253` would store the result with the wrong id for `DI_BIT` hint. Fixes lambdaclass#1205 * fix changelog.md --------- Co-authored-by: Pedro Fontana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace a substraction and shift-based logic by
.checked_subandfinding the right bit to avoid a
panic.Also fixed a bug where
m >= 253would store the result with the wrongid for
DI_BIThint.Added tests for both cases that confirm the bugs.
Fixes #1205
TITLE
Description
Description of the pull request changes and motivation.
Checklist