Skip to content

Conversation

@fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Apr 25, 2023

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Apr 25, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 3.582 ± 0.088 3.473 3.733 1.01 ± 0.03
head blake2s_integration_benchmark 3.551 ± 0.081 3.419 3.677 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.283 ± 0.122 4.140 4.458 1.01 ± 0.03
head compare_arrays_200000 4.228 ± 0.051 4.159 4.322 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.214 ± 0.042 3.166 3.294 1.00
head dict_integration_benchmark 3.240 ± 0.071 3.139 3.368 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.227 ± 0.058 5.134 5.341 1.00
head factorial_multirun 5.255 ± 0.090 5.115 5.407 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.173 ± 0.063 4.087 4.270 1.00
head fibonacci_1000_multirun 4.237 ± 0.076 4.136 4.343 1.02 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 150.3 ± 11.5 140.1 179.7 1.02 ± 0.08
head field_arithmetic_get_square_benchmark 146.9 ± 4.6 141.3 156.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 4.262 ± 0.105 4.189 4.551 1.05 ± 0.03
head integration_builtins 4.057 ± 0.052 3.992 4.130 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 3.932 ± 0.099 3.794 4.069 1.02 ± 0.03
head keccak_integration_benchmark 3.870 ± 0.054 3.804 3.967 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.402 ± 0.071 4.329 4.521 1.00
head linear_search 4.446 ± 0.081 4.284 4.547 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.598 ± 0.032 3.556 3.659 1.00
head math_cmp_and_pow_integration_benchmark 3.705 ± 0.054 3.620 3.766 1.03 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.390 ± 0.047 3.331 3.468 1.00
head math_integration_benchmark 3.392 ± 0.048 3.341 3.504 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 3.020 ± 0.044 2.979 3.128 1.00 ± 0.02
head memory_integration_benchmark 3.007 ± 0.038 2.958 3.070 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.940 ± 0.077 2.840 3.109 1.01 ± 0.03
head operations_with_data_structures_benchmarks 2.898 ± 0.045 2.845 2.991 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.028 ± 0.009 1.011 1.041 1.00
head pedersen 1.029 ± 0.023 0.985 1.063 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.875 ± 0.028 1.821 1.921 1.00 ± 0.02
head poseidon_integration_benchmark 1.870 ± 0.024 1.834 1.919 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.367 ± 0.036 3.309 3.416 1.00
head secp_integration_benchmark 3.384 ± 0.051 3.301 3.455 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.524 ± 0.148 2.442 2.932 1.01 ± 0.06
head set_integration_benchmark 2.499 ± 0.053 2.413 2.578 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.841 ± 0.094 4.721 5.006 1.00
head uint256_integration_benchmark 4.911 ± 0.132 4.772 5.088 1.01 ± 0.03

@fmoletta fmoletta marked this pull request as ready for review April 25, 2023 19:25
@MegaRedHand MegaRedHand added the whitelisted-hint Implementation of hint on whitelist directory label Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1053 (3b835c9) into main (86f233c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1053   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files          84       84           
  Lines       33810    33826   +16     
=======================================
+ Hits        33165    33181   +16     
  Misses        645      645           
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 98.98% <100.00%> (+0.01%) ⬆️
..._processor/builtin_hint_processor/secp/ec_utils.rs 99.50% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen enabled auto-merge April 26, 2023 08:46
@Oppen Oppen disabled auto-merge April 26, 2023 15:45
@Oppen Oppen enabled auto-merge April 26, 2023 16:07
@Oppen Oppen added this pull request to the merge queue Apr 26, 2023
Merged via the queue into main with commit 0f57c5d Apr 26, 2023
@Oppen Oppen deleted the new-hint-59 branch April 26, 2023 16:27
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Add hint

* Add integration test

* Add changelog entry

* Typo

* Fix invoked hint

* Update src/tests/cairo_run_test.rs

Co-authored-by: Mario Rugiero <[email protected]>

* Fix ec_double_assign_new_y

* fixes

* Fix integration test

* Clippy

---------

Co-authored-by: Mario Rugiero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

whitelisted-hint Implementation of hint on whitelist directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants