Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all uses of Span::def_site to Span::mixed_site #190

Closed
lambda-fairy opened this issue May 30, 2020 · 2 comments
Closed

Change all uses of Span::def_site to Span::mixed_site #190

lambda-fairy opened this issue May 30, 2020 · 2 comments

Comments

@lambda-fairy
Copy link
Owner

Span::def_site and Span::mixed_site do similar things, but the latter is stable. See the stabilization report for background.

After this change, we should be able to remove #![feature(proc_macro_def_site)] as well.

@vim-zz
Copy link

vim-zz commented Jun 11, 2020

Hi, first time here, I did as asked here and on #193, and it looks that all tests pass (at least those which passed before the change), anything I'm missing? anything else I should check?

@lambda-fairy
Copy link
Owner Author

@vim-zz I think #193 is all that needs to be done 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants