Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: charts are not timezone-aware #13

Open
mindreframer opened this issue Sep 13, 2024 · 1 comment
Open

Bug: charts are not timezone-aware #13

mindreframer opened this issue Sep 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mindreframer
Copy link

I have noticed by playing with the data after 22h Berlin time (UTC +2), that some impressions are missing. When switching to tomorrow, I could see them again.

Maybe it should be possible to somehow respect the timezone? Not sure, how much more complex the DB schema will get, but it was actually somewhat confusing to not be be able to see the the recent impressions in the dashboard. I thought this is somehow related to caching, an maybe it also was. Before 22h I had to restart the phoenix server to get the most recent entries from the requests tables to be shown in the dashboard.

2 possible options I could imagine:

  • expire the cache after new impressions (so-so perfmance-wise)
  • give the user the ability to re-fresh the stats per widget and maybe have an indicator of the timestamp, then the cache was created. That way the user can always decide if he/she wants to get the most up-to-date info or keep some-what stale values.
@mindreframer mindreframer changed the title BUG: charts are not timezone-aware Bug: charts are not timezone-aware Sep 13, 2024
@lalabuy948
Copy link
Owner

lalabuy948 commented Sep 14, 2024

Hi @mindreframer ,

Indeed data is cached and if you switch from default date range to today/tomorrow/(any new one) you will see new requests. Where on page refresh you might not see same behavior as previous values where cached.

In that regard, in the upcoming version I will disable it by default and make configurable via config/config.exs. You can take a look on this PR description.

Let me know if that PR going to fix your concerns.

p.s. Since, I accept the fact it was a bit of over-engineering from my side, as I already introduced separate read only connection cache seems a bit over kill. In new version will fix it.

@lalabuy948 lalabuy948 added the enhancement New feature or request label Sep 15, 2024
@lalabuy948 lalabuy948 self-assigned this Sep 15, 2024
This was referenced Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants