New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements to password_scorer #25

Open

1 of 4 tasks

lakiw opened this issue Nov 23, 2021 · 1 comment

Owner

lakiw commented Nov 23, 2021 •

edited

Loading

As I review the code, there is a lot of areas that need improvement:

Review how the multiword detector is trained on an existing grammar
This is a weird result. Track down what caused it: flipzd p 0.0 -1
Add support for piping guesses into it via stdin
It doesn't appear the OMEN portion of this utilizes encoding when loading Ngrams

Owner Author

lakiw commented Aug 16, 2023

Fixed the issue of why flipzd p 0.0 -1 was categorized as a password. It's because I wasn't correctly handling an OMEN score of -1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment