Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abort broken in 6.2.2 release #763

Open
jimmydief opened this issue Mar 15, 2022 · 2 comments
Open

abort broken in 6.2.2 release #763

jimmydief opened this issue Mar 15, 2022 · 2 comments

Comments

@jimmydief
Copy link

jimmydief commented Mar 15, 2022

A regression related to aborting requests seems to have occurred in the supertest 6.1.6 => 6.2.2 release. superagent was upgraded at that time so the root cause may be there.

Requests do not appear to be receiving the "aborted" event when aborted via supertest.

I originally reproduced in Node 14.16.1 but confirmed that the same behavior affects 16.14.0 as well.

Repro: https://github.com/jimmydief/supertest-abort-bug-repro

  System:
    OS: macOS 11.6.4
  Binaries:
    Node: 14.16.1 - /usr/local/bin/node
    npm: 6.14.12 - /usr/local/bin/npm
@alexsorokin-at
Copy link

I see this test failing on node 16.13.1 on any version of supertest (including 6.1.6), but passing on an earlier version of node (say 12.20.1).

@jimmydief
Copy link
Author

@alexsorokin-at I think that's due to nodejs/node#40775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants