Adds a command to generate the zz_generated.deepcopy.go files for the apis (googleforgames#3900)

* Adds a command to generate the zz_generated.deepcopy.go files for the apis
* Combines CRD client and deepcopy code generation into one script
* Updates boilerplate headers to 2024
* Generated code from gen-all-sdk-grpc
* Small update to template comment

Author: igooch

.github/ISSUE_TEMPLATE/kubernetes_update.md

@@ -738,12 +738,12 @@ gen-install: $(ensure-build-image)
 		--set agones.crds.cleanupOnDelete=false \
 		> $(mount_path)/install/yaml/install.yaml'
 
-# Generate the client for our CustomResourceDefinition
-gen-crd-client: $(ensure-build-image)
+# Generate the client, conversions, deepcopy, and defaults code for our CustomResourceDefinition
+gen-crd-code: $(ensure-build-image)
 	docker run --rm \
 		$(common_mounts) -w $(workdir_path) $(build_tag) bash -c "\
 		$(git_safe) && \
-		/root/gen-crd-client.sh && \
+		/root/gen-crd-code.sh && \
 		cd $(workdir_path)/pkg && goimports -w ."
 
 # Run a bash shell with the developer tools in it. (Creates the image if it doesn't exist)
@@ -848,14 +848,23 @@ update-go-deps:
 	$(DOCKER_RUN) go mod tidy
 	$(DOCKER_RUN) go mod vendor
 
-test-gen-crd-client:
-	mkdir -p build/tmp
-	mv ../pkg/client build/tmp
-	make gen-crd-client
-	diff_output=$$(diff -bBr build/tmp/client ../pkg/client); \
-	if [ -z "$$diff_output" ]; then \
-		echo "No differences found. Deleting build/tmp"; \
+test-gen-crd-code:
+	mkdir -p build/tmp/apis | mkdir -p build/tmp/client; \
+	cp -r ../pkg/apis/* build/tmp/apis | cp -r ../pkg/client/* build/tmp/client; \
+	make gen-crd-code; \
+	$(MAKE) diff-directory DIRECTORY=apis
+	$(MAKE) diff-directory DIRECTORY=client
+	# Delete build/tmp if the directory is empty
+	if [ ! "$(ls -A build/tmp)" ]; then \
+		echo "No differences found. Deleting empty directory build/tmp."; \
 		rm -r build/tmp; \
+	fi
+
+diff-directory:
+	diff_output=$$(diff -bBr build/tmp/$(DIRECTORY) ../pkg/$(DIRECTORY)); \
+	if [ -z "$$diff_output" ]; then \
+		echo "No differences found. Deleting build/tmp/$(DIRECTORY)"; \
+		rm -r build/tmp/$(DIRECTORY); \
 	else \
 		echo "Differences found."; \
 		echo "$$diff_output"; \

build/Makefile

@@ -1,4 +1,4 @@
-// Copyright 2023 Google LLC All Rights Reserved.
+// Copyright 2024 Google LLC All Rights Reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

build/README.md

@@ -1,4 +1,4 @@
-# Copyright 2023 Google LLC All Rights Reserved.
+# Copyright 2024 Google LLC All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

build/boilerplate.go.txt

@@ -38,3 +38,11 @@ kube::codegen::gen_client \
   /go/src/agones.dev/agones/pkg/apis
 
 echo "CRD client code generation complete."
+
+echo "Generating CRD conversions, deepcopy, and defaults code..."
+
+kube::codegen::gen_helpers \
+  --boilerplate /go/src/agones.dev/agones/build/boilerplate.go.txt \
+  /go/src/agones.dev/agones/pkg/apis
+
+echo "CRD conversions, deepcopy, and defaults code generation complete."

build/boilerplate.yaml.txt

@@ -116,10 +116,10 @@ steps:
   # Preventing Broken PR Merges in CI
   #
   - name: make-docker
-    id: test-gen-crd-client
+    id: test-gen-crd-code
     waitFor: [pull-build-image]
     dir: build
-    args: [test-gen-crd-client]
+    args: [test-gen-crd-code]
 
   #
   # Runs the linter -- but also builds the build image, if not able to download
@@ -128,7 +128,7 @@ steps:
     id: lint
     waitFor:
       - pull-build-image
-      - test-gen-crd-client
+      - test-gen-crd-code
       - test-gen-all-sdk-grpc
     dir: build
     args: [lint]  # pull the build image if it exists