HTTP2 is enabled by default

[ernado]

Why?

It is enabled here and configured here

Maybe it is more expected to enable http2 when TLS key pair is present, because http2 without TLS is unusable in current implementation?

[ernado]

dub of #89

[ernado]

Proposal:
Use http2 by default only with TLS
If user specifies explicitly to use http2, use it http mode as well as https
If user specifies explicitly to not use http2, dont use it at all.

This will solve possible issue when go implementation of http2 will support h2c (issue on http2 repo)

[vishr]

@ernado Thanks for your suggestions, I will consider them while making the change. In general, I am not very convinced about not allowing HTTP2 over TCP, there is already a PR pending but looks like it won't make it to the library. I would like to see HTTP2 being used for internal services where TLS is not needed.

For reference:

bradfitz/http2#59
bradfitz/http2#48

[ernado]

@vishr I would realy like to use h2c too.
I think that h2c can make it to the library, but it will be not enabled by default. There is no reason to forbid using HTTP2 over TCP at all.

[vishr]

Perfect, will do the changes at next opportunity.