chore: bump golangci-lint and semgrep version (#5404)

* chore: bump golangci-lint and semgrep version

* fix: delete not allowed property

* fix: delete not allowed property

* fix: delete golangci-lint deprecated vet

* fix: golangci lint run go target version

* fix: golangci-lint donot fail fast

* fix: code lint

* patch: pkg

* patch: pkg

Author: zijiren233

.github/workflows/check-semgrep.yml

@@ -29,7 +29,7 @@ jobs:
 
     container:
       # A Docker image with Semgrep installed. Do not change this.
-      image: returntocorp/semgrep:1.31.2
+      image: semgrep/semgrep:1.109.0
 
     # allow fails due to too many risks
     continue-on-error: true

.github/workflows/ci.yml

@@ -55,6 +55,7 @@ jobs:
     needs: [ resolve-modules ]
     runs-on: ubuntu-24.04
     strategy:
+      fail-fast: false
       matrix: ${{ fromJson(needs.resolve-modules.outputs.matrix) }}
     steps:
       - name: Checkout
@@ -71,6 +72,6 @@ jobs:
       - name: Run Linter
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.54.2
+          version: v1.64.5
           working-directory: ${{ matrix.workdir }}
           args: "--out-${NO_FUTURE}format colored-line-number"

.github/workflows/controllers.yml

@@ -66,6 +66,7 @@ jobs:
     needs: [ resolve-modules ]
     runs-on: ubuntu-24.04
     strategy:
+      fail-fast: false
       matrix: ${{ fromJson(needs.resolve-modules.outputs.matrix) }}
     steps:
       - name: Checkout
@@ -80,7 +81,7 @@ jobs:
       - name: Run Linter
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.54.2
+          version: v1.64.5
           working-directory: ${{ matrix.workdir }}
           args: "--out-${NO_FUTURE}format colored-line-number"
 

.github/workflows/services.yml

@@ -65,6 +65,7 @@ jobs:
     needs: [  resolve-modules ]
     runs-on: ubuntu-24.04
     strategy:
+      fail-fast: false
       matrix: ${{ fromJson(needs.resolve-modules.outputs.matrix) }}
     steps:
       - name: Checkout
@@ -78,7 +79,7 @@ jobs:
       - name: Run Linter
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.54.2
+          version: v1.64.5
           working-directory: ${{ matrix.workdir }}
           args: "--out-${NO_FUTURE}format colored-line-number"
 

.github/workflows/webhooks.yml

@@ -43,6 +43,7 @@ jobs:
     needs: [ resolve-modules ]
     runs-on: ubuntu-24.04
     strategy:
+      fail-fast: false
       matrix: ${{ fromJson(needs.resolve-modules.outputs.matrix) }}
     steps:
       - name: Checkout
@@ -59,7 +60,7 @@ jobs:
       - name: Run Linter
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.54.2
+          version: v1.64.5
           working-directory: ${{ matrix.workdir }}
           args: "--out-${NO_FUTURE}format colored-line-number"
 

.golangci.yml

@@ -1,17 +1,20 @@
 run:
+  go: "1.20"
+
   # timeout for analysis, e.g. 30s, 5m, default is 1m
   timeout: 5m
 
   # include test files or not, default is true
   tests: true
 
-  # default is true. Enables skipping of directories:
-  #   vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
-  skip-dirs-use-default: true
-  skip-dirs:
+  modules-download-mode: readonly
+
+issues:
+  # https://github.com/golangci/golangci-lint/pull/4509
+  exclude-dirs-use-default: true
+  exclude-dirs:
     - (^|/)fork($|/)
     - pkg/registry/save/lib/
-  modules-download-mode: readonly
 
 linters:
   # please, do not use `enable-all`: it's deprecated and will be removed soon.
@@ -27,7 +30,6 @@ linters:
     - misspell
     - whitespace
     - ineffassign
-    - vet
     - typecheck
     - errcheck
     - govet
@@ -39,13 +41,10 @@ linters:
 linters-settings:
   errcheck:
     check-type-assertions: false
-    ignore: fmt:.*
     exclude-functions:
       - io.Copy(*bytes.Buffer)
       - io.Copy(os.Stdout)
-
-# golangci.com configuration
-# https://github.com/golangci/golangci/wiki/Configuration
-service:
-  # use the fixed version to not introduce new linters unexpectedly
-  golangci-lint-version: latest
+  revive:
+    rules:
+      - name: dot-imports
+        disabled: true

pkg/apply/processor/context.go

@@ -18,8 +18,12 @@ package processor
 
 import "context"
 
-var commandKey struct{}
+var (
+	commandKey struct{}
+	envKey     struct{}
+)
 
+//nolint:staticcheck
 func WithCommands(ctx context.Context, commands []string) context.Context {
 	return context.WithValue(ctx, commandKey, commands)
 }
@@ -32,8 +36,7 @@ func GetCommands(ctx context.Context) []string {
 	return nil
 }
 
-var envKey struct{}
-
+//nolint:staticcheck
 func WithEnvs(ctx context.Context, envs map[string]string) context.Context {
 	return context.WithValue(ctx, envKey, envs)
 }

service/devbox/middleware/auth.go

@@ -21,10 +21,9 @@ func TokenAuth(c *gin.Context) {
 }
 
 func parseToken(token string) error {
-	_, err := jwt.Parse(token, func(token *jwt.Token) (interface{}, error) {
+	_, err := jwt.Parse(token, func(_ *jwt.Token) (interface{}, error) {
 		return []byte(os.Getenv("JWTSecret")), nil
 	})
-
 	if err != nil {
 		return err
 	}

service/devbox/middleware/auth_test.go

@@ -9,7 +9,7 @@ import (
 
 func TestAuth(t *testing.T) {
 	secret, _ := GenerateTokenWithExpiry("1234567890", time.Hour)
-	t.Logf(secret)
+	t.Log(secret)
 }
 
 // GenerateTokenWithExpiry generates a JWT token with only the expiration time

service/exceptionmonitor/helper/monitor/database_performance_monitor.go

@@ -195,7 +195,6 @@ func NumberToChinese(num int) string {
 		return "十" + numToChinese[unitDigit]
 	} else if unitDigit == 0 {
 		return numToChinese[tenDigit] + "十"
-	} else {
-		return numToChinese[tenDigit] + "十" + numToChinese[unitDigit]
 	}
+	return numToChinese[tenDigit] + "十" + numToChinese[unitDigit]
 }