Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Minor improvements for vfolder related commands #106

Merged
merged 2 commits into from
May 29, 2020

Conversation

achimnol
Copy link
Member

No description provided.

achimnol added 2 commits May 29, 2020 23:11
* fix: Allow use of the colon as the mount path mapping separator, like docker CLI,
  in addition to the equal sign.
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #106 into master will decrease coverage by 0.01%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   42.25%   42.23%   -0.02%     
==========================================
  Files          63       63              
  Lines        5855     5862       +7     
==========================================
+ Hits         2474     2476       +2     
- Misses       3381     3386       +5     
Impacted Files Coverage Δ
src/ai/backend/client/cli/run.py 21.26% <25.00%> (+0.02%) ⬆️
src/ai/backend/client/cli/vfolder.py 29.84% <40.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9228c...40df1d1. Read the comment docs.

@achimnol achimnol merged commit 24962fb into master May 29, 2020
@achimnol achimnol deleted the feature/minor-vfolder-cli-improvements branch May 29, 2020 14:26
achimnol added a commit that referenced this pull request May 29, 2020
* feat: Add -b/--base-dir option to the vfolder upload command.

* NOTE: Mount mapping with custom paths when creating sessions
  is not supported in 19.09.

Ported-From: master
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant