feat!: universal-addon migration

[jaygridley]

Description

Type of change

• A bug fix (PR prefix fix)
• A new feature (PR prefix feat)
• A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
• Adding missing tests or correcting existing tests (PR prefix test)
• Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
• Changes to our CI configuration files and scripts (PR prefix ci)
• Documentation only changes (PR prefix docs)

This PR migrates addon structure to the https://github.com/lablabs/terraform-aws-eks-universal-addon template.

Breaking Changes

• Variable irsa_assume_role_arn was renamed to irsa_assume_role_arns and changing its type from string to list(string).
• Variable storage_accounts was replaces by individual SA variables, i.e. application_controller_service_account_create, application_controller_service_account_name etc.
• When upgrading to this version of addon and using self-managed installation a new variable value self_managed_helm_release_name must be provided. It is also advised to set a different name for ArgoCD Application Helm release to avoid collision with self-managed Helm release and patch Helm release name ArgoCD Application uses for it release by specifying

  self_managed_helm_release_name = "argocd"
  helm_release_name              = "argocd-application" # a different name to avoid collision with the self-managed Helm release

  argo_spec = {
    source = {
      helm = {
        releaseName = "argocd" # override the release name to addopt resources created by the self-managed Helm release
      }
    }
  }

• When upgrading to this version you can expect recreation of existing IAM role due to name changes. Also, more roles will be created as now we have a dedicated role for each ArgoCD component.
• ArgoCD Helm chart and application were updated to 7.8.23, 2.14.9 respectively. Follow upgrade guides 1, 2 to migrate your configurations.

How Has This Been Tested?

• Upgrade path
• Re-creating with self-managed installation

[atyu1]

Please review my comments

[atyu1]

LGTM