Skip to content

Commit 8666117

Browse files
authored
fix: mark finalizers as computed field (#4)
1 parent 5ce661f commit 8666117

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ See [Basic example](examples/basic/README.md) for further information.
6262
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0 |
6363
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 4.19.0 |
6464
| <a name="requirement_helm"></a> [helm](#requirement\_helm) | >= 2.6.0 |
65-
| <a name="requirement_kubernetes"></a> [kubernetes](#requirement\_kubernetes) | >= 2.11.0 |
65+
| <a name="requirement_kubernetes"></a> [kubernetes](#requirement\_kubernetes) | >= 2.16.0 |
6666
| <a name="requirement_utils"></a> [utils](#requirement\_utils) | >= 0.17.0 |
6767

6868
## Modules
@@ -95,7 +95,7 @@ No modules.
9595
| <a name="input_argo_helm_enabled"></a> [argo\_helm\_enabled](#input\_argo\_helm\_enabled) | If set to true, the ArgoCD Application manifest will be deployed using Kubernetes provider as a Helm release. Otherwise it'll be deployed as a Kubernetes manifest. See Readme for more info | `bool` | `false` | no |
9696
| <a name="input_argo_helm_values"></a> [argo\_helm\_values](#input\_argo\_helm\_values) | Value overrides to use when deploying argo application object with helm | `string` | `""` | no |
9797
| <a name="input_argo_info"></a> [argo\_info](#input\_argo\_info) | ArgoCD info manifest parameter | <pre>list(object({<br> name = string<br> value = string<br> }))</pre> | <pre>[<br> {<br> "name": "terraform",<br> "value": "true"<br> }<br>]</pre> | no |
98-
| <a name="input_argo_kubernetes_manifest_computed_fields"></a> [argo\_kubernetes\_manifest\_computed\_fields](#input\_argo\_kubernetes\_manifest\_computed\_fields) | List of paths of fields to be handled as "computed". The user-configured value for the field will be overridden by any different value returned by the API after apply. | `list(string)` | <pre>[<br> "metadata.labels",<br> "metadata.annotations"<br>]</pre> | no |
98+
| <a name="input_argo_kubernetes_manifest_computed_fields"></a> [argo\_kubernetes\_manifest\_computed\_fields](#input\_argo\_kubernetes\_manifest\_computed\_fields) | List of paths of fields to be handled as "computed". The user-configured value for the field will be overridden by any different value returned by the API after apply. | `list(string)` | <pre>[<br> "metadata.labels",<br> "metadata.annotations",<br> "metadata.finalizers"<br>]</pre> | no |
9999
| <a name="input_argo_kubernetes_manifest_field_manager_force_conflicts"></a> [argo\_kubernetes\_manifest\_field\_manager\_force\_conflicts](#input\_argo\_kubernetes\_manifest\_field\_manager\_force\_conflicts) | Forcibly override any field manager conflicts when applying the kubernetes manifest resource | `bool` | `false` | no |
100100
| <a name="input_argo_kubernetes_manifest_field_manager_name"></a> [argo\_kubernetes\_manifest\_field\_manager\_name](#input\_argo\_kubernetes\_manifest\_field\_manager\_name) | The name of the field manager to use when applying the kubernetes manifest resource. Defaults to Terraform | `string` | `"Terraform"` | no |
101101
| <a name="input_argo_kubernetes_manifest_wait_fields"></a> [argo\_kubernetes\_manifest\_wait\_fields](#input\_argo\_kubernetes\_manifest\_wait\_fields) | A map of fields and a corresponding regular expression with a pattern to wait for. The provider will wait until the field matches the regular expression. Use * for any value. | `map(string)` | `{}` | no |

argo.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ locals {
22
argo_application_metadata = {
33
"labels" : try(var.argo_metadata.labels, {}),
44
"annotations" : try(var.argo_metadata.annotations, {}),
5-
"finalizers" : try(var.argo_metadata.finalizers, tolist(null))
5+
"finalizers" : try(var.argo_metadata.finalizers, [])
66
}
77
argo_application_values = {
88
"project" : var.argo_project

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ variable "argo_helm_values" {
239239

240240
variable "argo_kubernetes_manifest_computed_fields" {
241241
type = list(string)
242-
default = ["metadata.labels", "metadata.annotations"]
242+
default = ["metadata.labels", "metadata.annotations", "metadata.finalizers"]
243243
description = "List of paths of fields to be handled as \"computed\". The user-configured value for the field will be overridden by any different value returned by the API after apply."
244244
}
245245

versions.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ terraform {
88
}
99
kubernetes = {
1010
source = "hashicorp/kubernetes"
11-
version = ">= 2.11.0"
11+
version = ">= 2.16.0"
1212
}
1313
helm = {
1414
source = "hashicorp/helm"

0 commit comments

Comments
 (0)