Skip to content

Commit 89c13b8

Browse files
authored
Merge pull request #1523 from Bastian-Krause/bst/ruff
ruff: maintain configuration, format examples and labgrid.protocols
2 parents ec87797 + d8eac5c commit 89c13b8

40 files changed

+169
-161
lines changed

.github/workflows/reusable-unit-tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
pylint labgrid
5656
- name: Format with ruff
5757
run: |
58-
ruff format --check --diff labgrid/remote/
58+
ruff format --check --diff
5959
- name: Test with pytest
6060
run: |
6161
pytest -r a --cov-config .coveragerc --cov=labgrid --local-sshmanager --ssh-username runner -k "not test_docker_with_daemon"

examples/barebox/conftest.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import pytest
22

33

4-
@pytest.fixture(scope='session')
4+
@pytest.fixture(scope="session")
55
def command(target):
6-
barebox = target.get_driver('CommandProtocol')
6+
barebox = target.get_driver("CommandProtocol")
77
target.activate(barebox)
88
return barebox

examples/barebox/test_barebox.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
def test_barebox(command):
2-
stdout, stderr, returncode = command.run('version')
2+
stdout, stderr, returncode = command.run("version")
33
assert returncode == 0
44
assert stdout
55
assert not stderr
6-
assert 'barebox' in '\n'.join(stdout)
6+
assert "barebox" in "\n".join(stdout)
77

8-
stdout, stderr, returncode = command.run('false')
8+
stdout, stderr, returncode = command.run("false")
99
assert returncode == 1
1010
assert not stdout
1111
assert not stderr

examples/barebox/test_bootchooser.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33

44
def test_bootchooser(command):
5-
stdout, stderr, returncode = command.run('bootchooser -i')
5+
stdout, stderr, returncode = command.run("bootchooser -i")
66
if returncode == 127:
77
pytest.skip("bootchooser command not available")
88
assert returncode == 0
99
assert not stderr
10-
assert stdout[0].startswith('Good targets')
11-
assert stdout[1] != 'none'
10+
assert stdout[0].startswith("Good targets")
11+
assert stdout[1] != "none"

examples/barebox/test_sleep.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66
def test_sleep(command):
77
# measure the round-trip-time
88
timestamp = monotonic()
9-
stdout, stderr, returncode = command.run('true')
9+
stdout, stderr, returncode = command.run("true")
1010
elapsed_true = monotonic() - timestamp
1111
assert returncode == 0
1212
assert not stdout
1313
assert not stderr
1414

1515
timestamp = monotonic()
16-
stdout, stderr, returncode = command.run('sleep 1')
16+
stdout, stderr, returncode = command.run("sleep 1")
1717
elapsed_sleep = monotonic() - timestamp
1818
assert returncode == 0
1919
assert not stdout

examples/barebox/test_state.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33

44
def test_state(command):
5-
stdout, stderr, returncode = command.run('state')
5+
stdout, stderr, returncode = command.run("state")
66
if returncode == 127:
77
pytest.skip("state command not available")
88
assert returncode == 0
99
assert not stderr
10-
assert stdout[0] == 'registered state instances:'
10+
assert stdout[0] == "registered state instances:"
1111
assert len(stdout) > 1

examples/barebox/test_watchdog.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33

44
def test_watchdog(command):
5-
stdout, stderr, returncode = command.run('wd 1')
5+
stdout, stderr, returncode = command.run("wd 1")
66
if returncode == 127:
77
pytest.skip("wd command not available")
88
assert returncode == 0
@@ -11,6 +11,6 @@ def test_watchdog(command):
1111

1212
command._await_prompt()
1313

14-
stdout = command.run_check('echo ${global.system.reset}')
14+
stdout = command.run_check("echo ${global.system.reset}")
1515
assert len(stdout) == 1
16-
assert stdout[0] == 'WDG'
16+
assert stdout[0] == "WDG"

examples/deditec-relais8/deditec.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# log labgrid steps
1313
StepLogger.start()
1414

15-
t = Target('main')
15+
t = Target("main")
1616
r = DeditecRelais8(t, name=None, index=1)
1717
d = DeditecRelaisDriver(t, name=None)
1818

examples/deditec-relais8/deditec_remote.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# show labgrid steps on the console
1111
StepLogger.start()
1212

13-
e = Environment('import-dedicontrol.yaml')
13+
e = Environment("import-dedicontrol.yaml")
1414
t = e.get_target()
1515

1616
p = t.get_driver("DigitalOutputProtocol")

examples/docker/conftest.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import pytest
22

3-
@pytest.fixture(scope='session')
3+
4+
@pytest.fixture(scope="session")
45
def command(target):
5-
strategy = target.get_driver('DockerStrategy')
6+
strategy = target.get_driver("DockerStrategy")
67
strategy.transition("accessible")
7-
shell = target.get_driver('CommandProtocol')
8+
shell = target.get_driver("CommandProtocol")
89
return shell
9-

examples/docker/test_shell.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
def test_shell(command):
2-
stdout, stderr, returncode = command.run('cat /proc/version')
2+
stdout, stderr, returncode = command.run("cat /proc/version")
33
assert returncode == 0
44
assert len(stdout) > 0
55
assert len(stderr) == 0
6-
assert 'Linux' in stdout[0]
6+
assert "Linux" in stdout[0]
77

8-
stdout, stderr, returncode = command.run('false')
8+
stdout, stderr, returncode = command.run("false")
99
assert returncode != 0
1010
assert len(stdout) == 0
1111
assert len(stderr) == 0

examples/library/test.py

+7-5
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,17 @@
1515
# log labgrid steps
1616
StepLogger.start()
1717

18+
1819
def run_once(target):
19-
s = target.get_driver('BareboxStrategy')
20+
s = target.get_driver("BareboxStrategy")
2021
s.status = Status.unknown # force a power-cycle
21-
s.transition('barebox')
22-
cmd = target['CommandProtocol']
23-
cmd.run_check('test -e /dev/nand0')
22+
s.transition("barebox")
23+
cmd = target["CommandProtocol"]
24+
cmd.run_check("test -e /dev/nand0")
2425
target.deactivate(cmd)
2526

27+
2628
env = Environment(sys.argv[1])
27-
target = env.get_target('main')
29+
target = env.get_target("main")
2830
while True:
2931
run_once(target)

examples/modbusrtu/conftest.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import pytest
22

33

4-
@pytest.fixture(scope='session')
4+
@pytest.fixture(scope="session")
55
def instrument(target):
6-
_modbus = target.get_driver('ModbusRTUDriver')
6+
_modbus = target.get_driver("ModbusRTUDriver")
77
return _modbus

examples/network-test/pkg-replay-record.py

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from labgrid import Environment
1212
from labgrid.logging import basicConfig, StepLogger
1313

14+
1415
def generate_frame():
1516
frame = Ether(dst="11:22:33:44:55:66", src="66:55:44:33:22:11", type=0x9000)
1617
padding = "\x00" * (conf.min_pkt_size - len(frame))

examples/networkmanager/nm.py

+38-39
Original file line numberDiff line numberDiff line change
@@ -12,72 +12,71 @@
1212
StepLogger.start()
1313

1414

15-
e = Environment('nm.env')
15+
e = Environment("nm.env")
1616
t = e.get_target()
17-
d = t.get_driver('NetworkInterfaceDriver')
17+
d = t.get_driver("NetworkInterfaceDriver")
1818

1919
# based on https://developer.gnome.org/NetworkManager/stable/ch01.html, but adapted to python dicts
2020
s_client = {
21-
'connection': {
22-
'type': "802-11-wireless",
21+
"connection": {
22+
"type": "802-11-wireless",
2323
},
24-
'802-11-wireless': {
25-
'mode': "infrastructure",
26-
'ssid': "local-rpi",
24+
"802-11-wireless": {
25+
"mode": "infrastructure",
26+
"ssid": "local-rpi",
2727
},
28-
'802-11-wireless-security': {
29-
'key-mgmt': "wpa-psk",
30-
'psk': "obMinwyurArc5",
28+
"802-11-wireless-security": {
29+
"key-mgmt": "wpa-psk",
30+
"psk": "obMinwyurArc5",
3131
},
32-
'ipv4': {
33-
'method': "auto",
34-
'ignore-auto-dns': True,
35-
'ignore-auto-routes': True,
36-
'never-default': True,
32+
"ipv4": {
33+
"method": "auto",
34+
"ignore-auto-dns": True,
35+
"ignore-auto-routes": True,
36+
"never-default": True,
3737
},
38-
'ipv6': {
39-
'method': "link-local",
38+
"ipv6": {
39+
"method": "link-local",
4040
},
4141
}
4242
s_ap = {
43-
'connection': {
44-
'type': "802-11-wireless",
43+
"connection": {
44+
"type": "802-11-wireless",
4545
},
46-
'802-11-wireless': {
47-
'mode': "ap",
48-
'ssid': "local-rpi",
46+
"802-11-wireless": {
47+
"mode": "ap",
48+
"ssid": "local-rpi",
4949
},
50-
'802-11-wireless-security': {
51-
'key-mgmt': "wpa-psk",
52-
'psk': "obMinwyurArc5",
50+
"802-11-wireless-security": {
51+
"key-mgmt": "wpa-psk",
52+
"psk": "obMinwyurArc5",
5353
},
54-
'ipv4': {
54+
"ipv4": {
5555
#'method': "auto",
5656
#'method': "link-local",
57-
'method': "shared",
58-
'addresses': ["172.16.0.2/29"],
57+
"method": "shared",
58+
"addresses": ["172.16.0.2/29"],
5959
},
60-
'ipv6': {
61-
'method': "link-local",
60+
"ipv6": {
61+
"method": "link-local",
6262
},
6363
}
6464

6565
d.disable()
66-
d.wait_state('disconnected')
66+
d.wait_state("disconnected")
6767
print("access points after scan")
6868
pprint(d.get_access_points())
6969

7070
d.configure(s_ap)
71-
d.wait_state('activated')
71+
d.wait_state("activated")
7272
print("settings in AP mode")
7373
pprint(d.get_settings())
7474
print("state in AP mode")
7575
pprint(d.get_state())
7676

77-
#d.configure(s_client)
78-
#d.wait_state('activated')
79-
#print("settings in client mode")
80-
#pprint(d.get_settings())
81-
#print("state in client mode")
82-
#pprint(d.get_state())
83-
77+
# d.configure(s_client)
78+
# d.wait_state('activated')
79+
# print("settings in client mode")
80+
# pprint(d.get_settings())
81+
# print("state in client mode")
82+
# pprint(d.get_state())

examples/power/power_example.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
@pytest.fixture()
55
def pdu(target):
6-
return target.get_driver('NetworkPowerDriver')
6+
return target.get_driver("NetworkPowerDriver")
77

88

99
def test_something(pdu):

examples/pyvisa/pyvisa_example.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33

44
@pytest.fixture()
55
def signal_generator(target):
6-
return target.get_driver('PyVISADriver').get_session()
6+
return target.get_driver("PyVISADriver").get_session()
77

88

99
def test_with_signal_generator_example(signal_generator):
10-
signal_generator.write('*RST')
10+
signal_generator.write("*RST")
1111

1212
# Setup channel 1
13-
signal_generator.write('C1:BSWV WVTP,SQUARE,HLEV,5,LLEV,0,DUTY,50')
13+
signal_generator.write("C1:BSWV WVTP,SQUARE,HLEV,5,LLEV,0,DUTY,50")
1414
# Switch on channel 1
15-
signal_generator.write('C1:OUTP ON,LOAD,HZ,PLRT,NOR')
15+
signal_generator.write("C1:OUTP ON,LOAD,HZ,PLRT,NOR")

examples/qemu-networking/test_qemu_networking.py

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15+
1516
def test_shell(shell_command):
1617
shell_command.run("true")
1718

examples/remote/test_barebox.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
def test_target(target):
2-
barebox = target.get_driver('CommandProtocol')
2+
barebox = target.get_driver("CommandProtocol")
33
target.activate(barebox)
44

5-
stdout, stderr, returncode = barebox.run('version')
5+
stdout, stderr, returncode = barebox.run("version")
66
assert returncode == 0
77
assert stdout
88
assert not stderr
9-
assert 'barebox' in '\n'.join(stdout)
9+
assert "barebox" in "\n".join(stdout)
1010

11-
stdout, stderr, returncode = barebox.run('false')
11+
stdout, stderr, returncode = barebox.run("false")
1212
assert returncode == 1
1313
assert not stdout
1414
assert not stderr

examples/shell/conftest.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import pytest
22

33

4-
@pytest.fixture(scope='session')
4+
@pytest.fixture(scope="session")
55
def command(target):
6-
shell = target.get_driver('CommandProtocol')
6+
shell = target.get_driver("CommandProtocol")
77
target.activate(shell)
88
return shell

examples/shell/test_hwclock.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
def test_hwclock_rate(command):
55
"""Test that the hardware clock rate is not too inaccurate."""
6-
result = command.run_check('hwclock -c | head -n 3')
6+
result = command.run_check("hwclock -c | head -n 3")
77
hw_time, sys_time, freq_offset_ppm, tick = result[-1].strip().split()
88
assert abs(int(freq_offset_ppm)) < 1000
99

@@ -15,11 +15,11 @@ def test_hwclock_value(command):
1515
"""
1616

1717
def get_time():
18-
result = command.run_check('hwclock --utc --show')[0].strip()
19-
return datetime.strptime(result, '%Y-%m-%d %H:%M:%S.%f+0:00')
18+
result = command.run_check("hwclock --utc --show")[0].strip()
19+
return datetime.strptime(result, "%Y-%m-%d %H:%M:%S.%f+0:00")
2020

2121
def set_time(time):
22-
time = time.strftime('%Y-%m-%d %H:%M:%S.%f+0:00')
22+
time = time.strftime("%Y-%m-%d %H:%M:%S.%f+0:00")
2323
command.run_check(f'hwclock --utc --set --date "{time}"')
2424

2525
offset = abs((get_time() - datetime.utcnow()).total_seconds())

0 commit comments

Comments
 (0)