Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect L4 offset for IP packets with Options field #30

Open
aka320 opened this issue Feb 14, 2023 · 2 comments · May be fixed by #54
Open

Incorrect L4 offset for IP packets with Options field #30

aka320 opened this issue Feb 14, 2023 · 2 comments · May be fixed by #54
Assignees

Comments

@aka320
Copy link

aka320 commented Feb 14, 2023

  • IP header length is variable (20 to 60 bytes) due to the options field which is optional.
  • So L4 offset is not always fixed at the default offset of 20 bytes (struct iphdr) from the start of IP header.
  • Actual L4 offset is derived from IHL field (4 times IHL) in the IP header, which includes the options as well.
@evershalik
Copy link

@aka320, can you elaborate the issue a little more. Actuallly I am not getting the specific concern of this issue. Can you tell, which part/code are you specifically talking about. I wanna know more about the issue so that I can have a look on it.

@aka320
Copy link
Author

aka320 commented Mar 25, 2023

@evershalik Please see the LFN-meeting-recording where I have discussed this issue (starts from 21:25). I have shown the code as well there. Let me know if you have any questions further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants