Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to create timetz with precision columns #910

Closed
dunkelbraun opened this issue Mar 13, 2024 · 3 comments · Fixed by #911
Closed

Unable to create timetz with precision columns #910

dunkelbraun opened this issue Mar 13, 2024 · 3 comments · Fixed by #911
Labels
bug Something isn't working postgres Related to PostgreSQL

Comments

@dunkelbraun
Copy link
Contributor

When creating a timetz(p) column with the schema builder:

await db.schema
  .createTable("test")
  .addColumn("t", "timetz(4)")
  .execute();

parseDataTypeExpressionthrows an Error:

Error: invalid column data type "timetz(4)"
❯ Module.parseDataTypeExpression node_modules/kysely/dist/esm/parser/data-type-parser.js:14:11
@dunkelbraun dunkelbraun mentioned this issue Mar 13, 2024
Merged
@igalklebanov igalklebanov added bug Something isn't working postgres Related to PostgreSQL labels Mar 13, 2024
@koskimas
Copy link
Member 

.addColumn("t", sql`timetz(4)`)

@koskimas
Copy link
Member

Oh, that's actually a supported type. Needs fixing.

@koskimas koskimas reopened this Mar 13, 2024
@dunkelbraun
Copy link
Contributor Author

I forgot to mention that it was for the PostgreSQL dialect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo on timetz regex dunkelbraun/kysely
3 participants
@dunkelbraun @koskimas @igalklebanov