Update NodeMessage.ts #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been using Veza for a while for my Discord bot because it's used by Kurasuta which is my sharding manager. Ever since I started using Veza I noticed the issue that it sometimes tries to write on the Socket when it cannot. I've reported this on 12/07/2020 in Veza's support server, I showed my temporary fix. There have been no changes since then and it's starting to annoy me that I have to change it manually every time otherwise it crashes my entire process when I restart separate clusters. This change should only be temporary until a real fix has been implemented but it will save me and other bot developers a lot of time and effort to constantly update this line. Although it falls silent when it should at least throw an error I've been using it like this in production with 98k servers without any issues for the past months.
kyranet
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using Veza for a while for my Discord bot because it's used by Kurasuta which is my sharding manager. Ever since I started using Veza I noticed the issue that it sometimes tries to write on the Socket when it cannot. I've reported this on 12/07/2020 in Veza's support server, I showed my temporary fix. There have been no changes since then and it's starting to annoy me that I have to change it manually every time otherwise it crashes my entire process when I restart separate clusters. This change should only be temporary until a real fix has been implemented but it will save me and other bot developers a lot of time and effort to constantly update this line. Although it falls silent when it should at least throw an error I've been using it like this in production with 98k servers without any issues for the past months.
Description of the PR
Semver Classification