Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Helm3 #97

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Helm3 #97

merged 3 commits into from
Jun 18, 2020

Conversation

piotrmiskiewicz
Copy link
Collaborator

@piotrmiskiewicz piotrmiskiewicz commented Jun 5, 2020 •
edited
Loading

Description

Helm Broker use Helm3 instead of Helm2.

Related issue(s)
Related: #95

@piotrmiskiewicz
Copy link
Collaborator Author

/retest

@piotrmiskiewicz
Copy link
Collaborator Author

/retest

3 similar comments
@piotrmiskiewicz
Copy link
Collaborator Author

/retest

@piotrmiskiewicz
Copy link
Collaborator Author

/retest

@piotrmiskiewicz
Copy link
Collaborator Author

/retest

@piotrmiskiewicz piotrmiskiewicz marked this pull request as ready for review June 18, 2020 05:06
@piotrmiskiewicz
Copy link
Collaborator Author

piotrmiskiewicz commented Jun 18, 2020 •
edited
Loading

Simple testing scenario:

  1. Create namespaces:
 kubectl create ns catalog
 kubectl create ns helm-broker
  1. Install SC:
helm3 install catalog svc-cat/catalog --namespace catalog --set asyncBindingOperationsEnabled=true
  1. Install HB:
    helm3 install helm-broker charts_v3/helm-broker --namespace helm-broker
    kubectl apply -f hack/examples/sample-addons.yaml
  2. Create redis instance:
    kubectl apply -f hack/examples/redis-instance.yaml

polskikiel
polskikiel reviewed Jun 18, 2020
View reviewed changes
internal/model.go
ReleaseTime time.Time
Revision int
Config *chartv2.Config
ConfigValues map[string]interface{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to call above fields: ConfigV2 and ConfigV3?

polskikiel
polskikiel previously approved these changes Jun 18, 2020
View reviewed changes
polskikiel
polskikiel previously approved these changes Jun 18, 2020
View reviewed changes
polskikiel
polskikiel previously approved these changes Jun 18, 2020
View reviewed changes
majakurcius
majakurcius reviewed Jun 18, 2020
View reviewed changes
charts_v3/helm-broker/README.md Outdated Show resolved Hide resolved
charts_v3/helm-broker/README.md Show resolved Hide resolved
@piotrmiskiewicz piotrmiskiewicz merged commit d969b46 into SAP-archive:master Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@polskikiel polskikiel polskikiel approved these changes

@majakurcius majakurcius majakurcius approved these changes

@adamwalach adamwalach Awaiting requested review from adamwalach

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@bszwarc bszwarc Awaiting requested review from bszwarc

@jasiu001 jasiu001 Awaiting requested review from jasiu001

@kazydek kazydek Awaiting requested review from kazydek

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@ksputo ksputo Awaiting requested review from ksputo

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@mszostok mszostok Awaiting requested review from mszostok

@PK85 PK85 Awaiting requested review from PK85 PK85 is a code owner

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrmiskiewicz @polskikiel @majakurcius