Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working anymore #49

Closed
ValerioTomaino opened this issue Sep 7, 2022 · 16 comments
Closed

not working anymore #49

ValerioTomaino opened this issue Sep 7, 2022 · 16 comments

Comments

@ValerioTomaino
Copy link

ValerioTomaino commented Sep 7, 2022

today i tried downloading some videos from sharepoint in the same way and settings of the past and it's not working. it opens the video page and can't load it. if i open the video myself, i can see it.

edit:
this is the error page
Immagine 2022-09-07 101908
if from here i copy the link of the video opened in another browser (same link i think), it works

@kylon
Copy link
Owner

kylon commented Sep 7, 2022

any error?
keep in mind the video will not play on sharedown, thats how it works

it seems they are moving everyone to stream on sharepoint now, but download should work and it works here too

@ValerioTomaino
Copy link
Author

nope, no errors from sharedown, seems like it just can't download it unless i do the previous trick

@kylon
Copy link
Owner

kylon commented Sep 7, 2022

is the link the correct one for sharedown?

@kylon
Copy link
Owner

kylon commented Sep 7, 2022

i cant repro, it seems a redirect happening after your login

what login method?
have you tried to enable chrome data folder and retry download after the first fail?

should log url changes to log file to see if we can find when it goes wrong
Sharedownt.zip

@ValerioTomaino
Copy link
Author

the login is microsoft one for institutional account, for redirections i don't know, everything is enabled i'll try get the logs for you

@sato-shi
Copy link

sato-shi commented Sep 21, 2022

I saw similar issues. I changed "preload.js" to use Google Chrome instead of Chromium as browser in Puppeteer. Now I can download again.

function _getPuppeteerArgs(puppyExePath, userdataFold) {
        const pargs = {
            //executablePath: _getPuppeteerExecutablePath(puppyExePath),
            executablePath:"/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome",
            headless: false,
            args: ['--disable-dev-shm-usage']
        };

@tkgmomosheep
Copy link

I saw similar issues. I changed "preload.js" to use Google Chrome instead of Chromium as browser in Puppeteer. Now I can download again.

function _getPuppeteerArgs(puppyExePath, userdataFold) {
        const pargs = {
            //executablePath: _getPuppeteerExecutablePath(puppyExePath),
            executablePath:"/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome",
            headless: false,
            args: ['--disable-dev-shm-usage']
        };

For Windows, use the code snippet below

    function _getPuppeteerArgs(puppyExePath, userdataFold) {
        const pargs = {
          executablePath:
            "C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe",
          headless: false,
          args: ["--disable-dev-shm-usage"],
        };

@kylon
Copy link
Owner

kylon commented Oct 7, 2022

weird, i still see no error on my pc
maybe i ll add an option to set chrome as browser

@BorisDeGraaff
Copy link

BorisDeGraaff commented Oct 31, 2022

today i tried downloading some videos from sharepoint in the same way and settings of the past and it's not working. it opens the video page and can't load it. if i open the video myself, i can see it.

edit: this is the error page Immagine 2022-09-07 101908 if from here i copy the link of the video opened in another browser (same link i think), it works

I have the same issue, how does your trick exactly work? Opening the link in another chrome browser does nothing for me.

Edit: updated my version to latest release (5.1.0), new issues appeared. Downgraded to a previous release (5.0.2), this issues appeared to be present again, but now the thing happened which kylon described: the browser with the error closed, but the video did in fact download.

Unfortunately I don't remember which version I was coming from, but it was an old one downloaded around late 2021 I think.

@ValerioTomaino
Copy link
Author

ValerioTomaino commented Nov 1, 2022 via email

@brianchen0
Copy link

Tried to download using Chrome instead of Chromium, still shows the error as below.

image

image

@kylon
Copy link
Owner

kylon commented Nov 12, 2022

Tried to download using Chrome instead of Chromium, still shows the error as below.

image

image

this is a different thing, see #54

@brianchen0
Copy link

Tried to download using Chrome instead of Chromium, still shows the error as below.
image
image

this is a different thing, see #54

Got it, thanks Kylon

@kylon
Copy link
Owner

kylon commented Nov 17, 2022

@ValerioTomaino
please try 5.2.1 release

@kylon
Copy link
Owner

kylon commented Dec 11, 2022

closing for inactivity, should be fixed in latest release

@kylon kylon closed this as completed Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants