Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saving partial results? #47

Closed
gg4u opened this issue Jul 13, 2022 · 3 comments
Closed

saving partial results? #47

gg4u opened this issue Jul 13, 2022 · 3 comments

Comments

@gg4u
Copy link

gg4u commented Jul 13, 2022

I am experiencing this issue with some videos.
The download of fragments works until the end of both video and audio streams, but just at the merging of the two, there is an error (I cannot tell if the error is in the merging or in the last bit of audio, I only see an exit 1 error).

I think it could be useful an option to persist the two tracks, instead of removing them from the temporary folder, so that one may attempt to fix it later or to inspect if some of the two tracks are somehow corrupted that prevent a final merge.
What do you think?

Note the error occurred with default throttling, I m trying to lower it and see if something change.

P.s. can you explain what throttling is and how it affects in this context ?

@kylon
Copy link
Owner

kylon commented Jul 13, 2022

Throttle option is for when you get blocked by sharepoint because of too many downloads

The issue you describe sounds like #20 and the others open about this

Are you using latest ytdlp?
I can add an option to disable automatic delete on error

@gg4u
Copy link
Author

gg4u commented Jul 13, 2022

The issue you describe sounds like #20 and the others open about this

Indeed it seems so, but using the last ytdlp.

I can add an option to disable automatic delete on error
I think it can help.

I was able to manually copy the copies of .mp4 and .m4a files, and merge them with ffmpeg.
But since they are deleted as soon as t.m4a is finished downloading and an error -1 is found, they do not persit.
So I could only copy a .m4a that is not completed, but it worked for merging.

If you persist the files, eventually one can proceed to merge, or could also merge them automatically but add a suffix indicating that the file was recovered e.g.

[name_file]_RECOVERED.mp4

@kylon
Copy link
Owner

kylon commented Jul 13, 2022

Hm, yea i can try that, iirc there is an option to not generate fragments but merge the file while downloading (it still gives you error) but you end up with a video file
I dont remember tho if when i tried the file was valid after the error

@kylon kylon closed this as completed in 18204b0 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants