Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue compiling for current nightly OF #147

Open
javl opened this issue Apr 6, 2018 · 0 comments
Open

Issue compiling for current nightly OF #147

javl opened this issue Apr 6, 2018 · 0 comments

Comments

@javl
Copy link
Contributor

javl commented Apr 6, 2018

When trying to run ofxFaceTracker with the current nightly (which I believe is nearing 0.10.0) I get the following error:

of/addons/ofxFaceTracker/src/ofxFaceTracker.cpp:45:1: 
error: control reaches end of non-void function [-Werror=return-type]

This function is vector<int> ofxFaceTracker::getFeatureIndices(Feature feature) which returns a vector related to different facial features (case LEFT_EYE_TOP: return consecutive(36, 40);), but if nothing gets caught by the switch statement, nothing will be returned.
I fixed / hacked this by simply adding return std::vector<int>(0, 0); as the last line of the function, which seems to work.

I'd make a pull request with my 'fix', but as I'm not sure what it is I changed, I thought creating an issue might be better.

Sidenote: Arturo mentioned somewhere "we are moving towards using std:: explicitly in headers to at some point remove the global include for std". The ofFaceTracker script still uses plain vector in some places, which might have to be changed to std::vector at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant