Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact dashboard #60

Merged
merged 41 commits into from
May 9, 2023
Merged

Compact dashboard #60

merged 41 commits into from
May 9, 2023

Conversation

KK1L
Copy link
Contributor

@KK1L KK1L commented Jan 29, 2023

As a first step to compacting some of the screens I started with the main Dashboard. I integrated the radio titles into the Op label on the Radio1 and 2 info along the bottom and removed the titles from a few of the other blocks.

To allow the radio names to be displayed I added "msg.RadioNames=global.get('PCs');" to the UTF8 function to allow me to use the names the labels for Radio 1 Operator Dashboard and Radio 2 Operator Dashboard.

kd9lsv and others added 28 commits January 8, 2023 20:16
* Simplify Map Init Layers.

* Ui Group Modifications

* SQL Query Callsign from DB

* Fixed  kylekrieg#17, E16
Added Auto Populate Callsign
Added Auto Populate Radio

* Fixed kylekrieg#12 by adding "Full Exchange"(all)

* Working on kylekrieg#16 kylekrieg#17 Needs work still

* OP Competition SQL S&P Fix

* Create changelog.md

* Added great circle lines configuation group

* Main dashboard CSS Updates

* Part2 UI Cleanup

* Great circle lines on off and changed radio1 & radio2 SQL commands

* bug fixes 20221210

* Chart Resizing fixed.

* fix kylekrieg#15 Update Version on Config page. States Will not allow you to change version if pending changes on flow.

* Reorganized Config Page. Remove duplicate for kylekrieg#16 and kylekrieg#17

* Update package.json to new version

* Changed package to update on dashboard refresh.

* Fixed for all project folders.

* Updated Checkout Command to folder.

* Add debug node for configuration

* 30 lightning (kylekrieg#31)

Resolves kylekrieg#30. Added node.status to many function nodes. Disabled current backup and restore function in lieu of node-red context storage.

Co-authored-by: kd9lsv <[email protected]>

* Fixed IsFocus in Radio Data for Radio2

* Op Page CSS Rework.

* Update CSS

* Removed Spot Rate

* 10 & 30 Minute Data

* Band Stats CSS Matching

* Band and Radio Values CSS.

* Band stats chart CSS updates

* PC Name Issue

* Cleaned Up Radio Input Manually. Pending SQL.

* Config Page Redesign (kylekrieg#33)

* Config Restructure Part 1.

* Flip Locks on Dashboard

* Setup Score UDP and Left off.

* Fixed ui to fill variables in forms.

* Clean UI Changes and turned off HTTP OnlineScoreBoard

* Update Changelog for PR.

* Update to version V1.0.0

Co-authored-by: kylekrieg <[email protected]>
Co-authored-by: AA0Z <[email protected]>
* v1.0.1 Made Sure Restart nodes were connected.

* v1.1.0 Scores for dashboard flow are calculated after QSO UDP.
Config Headers larger
Reorganize Map Config Group
* Fix docs part 1.

* Remove Previous data that need to added to Issues.

* Remove Unused pictures from Docs due to google photos library.

* Relative Pictures instead in links.

* Remove json tag due to not being valid json

* Update READMe to relative not absolute.
@KK1L
Copy link
Contributor Author

KK1L commented Jan 29, 2023

FIXED!! Crap...i requested to pull into main not dev! darn...twice same mistake.

@KK1L KK1L changed the base branch from master to dev January 29, 2023 03:11
@kd9lsv
Copy link
Collaborator

kd9lsv commented Jan 29, 2023

Ron,

Your commits were not including the latest changes to dev. I rebased the branch upon dev to include the additional changes that I have made in between the other Tempateure PR and this requiring forced pushing the changes up. and associated changes.

Please pull these changes down before you create another commit. See below for git tree to clarify branches.

image

I am still looking at the rest of the changes but for sure I know that 5 digit distance sizes are too big.
image

I am also letting @kylekrieg initially look at this for QA on the changes.

Let me know if you have any issues.

@KK1L
Copy link
Contributor Author

KK1L commented Jan 29, 2023

Thanks. I will get the hang of this. I was not offered any pushes when I committed. Probably missed a step. In see 9 pull and 9 pushes which I am merging on my local now.

Oh and PLEASE QA is welcomed!

@kd9lsv
Copy link
Collaborator

kd9lsv commented Jan 29, 2023

I still have a issue with what you did last time. You merge both commits which duplicated the same commits in series. To become even with github, please force-pull (pull --force) using the terminal on the Node-Red machine.

@KK1L
Copy link
Contributor Author

KK1L commented Jan 29, 2023 via email

@KK1L
Copy link
Contributor Author

KK1L commented Jan 29, 2023 via email

@kd9lsv
Copy link
Collaborator

kd9lsv commented Jan 30, 2023

No, by doing the force pull it should have removed all outstanding commits unless you created the 12 additional commits? Your log should have the commits pictured below.

If you have trouble to start from github, I would recommend creating a new local branch git checkout -b <name> origin/compact_listings. If you have extra commits, then you would need to cherry-pick the needed commits.

image

@KK1L
Copy link
Contributor Author

KK1L commented Jan 30, 2023 via email

@KK1L
Copy link
Contributor Author

KK1L commented Jan 30, 2023

Hi Connor,

I ended up creating a new local branch git checkout -b cleanup_compact_listings origin/compact_listings and now I show "Already up to date" for force pull and no pushes or pulls needed on the ui interface for sharing. So that should have gotten the pull request squared away.

I then made a few edits and will commit and sync. For SO1V and SO2R the Dashboard and RadioInfo will correctly show results. See the note below on multi-op, but y'all probably already know it is broken.

_Note: multi-op mode is broken...not by me, but in general. In multi_op mode the station determination in Radio Info, Database, and Dashboard rely on RadioInfo.StationName which is the NetBios name of the computer sending the info. I have started to give it some though how to associate this StationName with one of the PC names someone would like to assign in node-red. You have to log the various StationNames that come across and build a database...UGH. Using RadioName is not helpful since that comes from which radio type is assigned in the Radio column of the Hardware tab of N1MM which is not unique per PC.

Bottom line is it seems that assigning names to the stations from the config panel is problematic. Assigning a name dynamically as the reports come in from the various stations on the network is possible. There is StationName from RadioInfo and also in ContactInfo along with NetworkedCompNr which combined could build and indexed list 0 through 8 of StationNames._

@kylekrieg
Copy link
Owner

kylekrieg commented Jan 30, 2023 via email

@KK1L
Copy link
Contributor Author

KK1L commented Jan 30, 2023 via email

@kd9lsv kd9lsv linked an issue Jan 30, 2023 that may be closed by this pull request
1 task
@kd9lsv kd9lsv requested review from kd9lsv and removed request for kd9lsv January 30, 2023 23:25
@KK1L
Copy link
Contributor Author

KK1L commented Feb 17, 2023

Have not had a chance to monkey with this in a bit...sorry. I have noticed that the CPU usage is significantly higher with this code and I have not found what of the simple changes that were made caused this issue.

@kd9lsv
Copy link
Collaborator

kd9lsv commented Feb 18, 2023

Ron,

No worries, I have been not doing much with this week.
Note, I found the biggest issue when I had the same issue if something is looping and running constant without delay.

I am hoping to get back on tackling more issues, but if you need additional help, let me know.

73,
Connor

@kd9lsv
Copy link
Collaborator

kd9lsv commented Apr 8, 2023

@KK1L I found the problem with the computer latch up as one of the UI-items (tempature) would send a result upon receive data which caused an endless feedback loop.
image

@KK1L
Copy link
Contributor Author

KK1L commented Apr 8, 2023 via email

@KK1L
Copy link
Contributor Author

KK1L commented Apr 8, 2023

@kd9lsv I made the change and VIOLA(!) CPU useage is back to normal...so awesome. Frankly that was one of the reasons I had not tinkered more with the flow. Silly to make changes and perpetuate a flaw. Now I can bravely move forward.

@kd9lsv
Copy link
Collaborator

kd9lsv commented Apr 8, 2023

LOL. I am just trying to get back in the swing of things and are wanting to make sure you changes get implemented. I also had that issue a long time ago, when I updated the whole thing for v1.0.0 .

If there is anything I need to help fix to implement, please let me know.

@KK1L
Copy link
Contributor Author

KK1L commented Apr 8, 2023

That was the outstanding issue for the compact dashboard update and having the radio names show up in Radio Info.
Getting the famous "Authentication required for repository" issue. I have to refigure out how to fix that so I can synch again.

@kd9lsv
Copy link
Collaborator

kd9lsv commented Apr 8, 2023

Make sure you are on the correct branch and pushing to the correct fork.

@kd9lsv kd9lsv merged commit 2153156 into kylekrieg:dev May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard the main dashboard page feature-request New feature or request
Projects
3 participants