Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageRef inside Pointer is almost useless. #25

Closed
vitvakatu opened this issue May 12, 2017 · 2 comments
Closed

StorageRef inside Pointer is almost useless. #25

vitvakatu opened this issue May 12, 2017 · 2 comments

Comments

@vitvakatu
Copy link
Collaborator

I suggest to replace it with some uid

@kvark
Copy link
Owner

kvark commented May 12, 2017

Upon further inspection, it appears that you are right - it's not used for anything other than keeping the storage alive and verification. Since we can't do much without the storage anyway, we can replace the verification with some UID and be happy with it.

The change would have some far-fetching consequences, actually:

  1. faster Pointer creation/cloning, as well as storage locking
  2. no need for StorageRef with its Arc<RwLock<Storage>>> any more
  3. simpler UpgradeErr

@kvark
Copy link
Owner

kvark commented May 12, 2017

Also please note that this issue is in direct conflict with #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants