Skip to content
This repository has been archived by the owner on Nov 27, 2021. It is now read-only.

Push Protobuf binding generation into the Docker step #22

Open
mieubrisse opened this issue Feb 10, 2021 · 4 comments
Open

Push Protobuf binding generation into the Docker step #22

mieubrisse opened this issue Feb 10, 2021 · 4 comments

Comments

@mieubrisse
Copy link
Contributor

mieubrisse commented Feb 10, 2021

As it stands, the regenerate-protobuf-output.sh isn't part of the CI build chain. This means that users need to run it locally on their machine to regenerate the Protobuf bindings. However, once we have more than one developer, this means that the output will be nondeterministic.

To fix, we need to push the Protobuf binding generation into the Docker build step; this is pain because we'll both need to generate the bindings locally (so the user's IDE doesn't get confused by missing files) as well as generate them inside the Docker image as the lib is built.

When this is done, we can get rid of https://github.com/kurtosis-tech/rust-protobuf-binding-generator

@mieubrisse
Copy link
Contributor Author

For Rust, we can likely use the build.rs pre-compilation hook; Go would need to be figured out

@mieubrisse
Copy link
Contributor Author

Potentially replace with buf.build

@mieubrisse
Copy link
Contributor Author

Synced with Buf; this is a very strong candidate for replacing with them

@mieubrisse
Copy link
Contributor Author

In the meantime, we could use https://github.com/kurtosis-tech/developer-tools/issues/27 to standardize the generation across our team

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant